GNOME Bugzilla – Bug 784715
dashdemux: Add support webvtt subtitle stream
Last modified: 2017-07-18 07:46:44 UTC
Enable exposing webvtt subtitle streams.
Created attachment 355203 [details] [review] dashdemux: Add support webvtt subtitle stream Sample stream: https://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd
Review of attachment 355203 [details] [review]: ::: ext/dash/gstmpdparser.c @@ +5750,3 @@ return "audio/x-m4a"; + } else if (strcmp (mimeType, "text/vtt") == 0) { + return "application/x-subtitle-vtt"; webvttenc from gst-plugins-bad uses "text/vtt"
(In reply to Sebastian Dröge (slomo) from comment #2) > Review of attachment 355203 [details] [review] [review]: > > ::: ext/dash/gstmpdparser.c > @@ +5750,3 @@ > return "audio/x-m4a"; > + } else if (strcmp (mimeType, "text/vtt") == 0) { > + return "application/x-subtitle-vtt"; > > webvttenc from gst-plugins-bad uses "text/vtt" webvttenc seems to encoder element but we need to subparse element to parse it. Factory Details: Rank primary (256) Long-name Subtitle parser Klass Codec/Parser/Subtitle Description Parses subtitle (.sub) files into text streams .... Pad Templates: SINK template: 'sink' Availability: Always Capabilities: application/x-subtitle application/x-subtitle-sami application/x-subtitle-tmplayer application/x-subtitle-mpl2 application/x-subtitle-dks application/x-subtitle-qttext application/x-subtitle-lrc *application/x-subtitle-vtt*
Comment on attachment 355203 [details] [review] dashdemux: Add support webvtt subtitle stream Ah great, inconsistencies :) Can you also provide a patch for webvttenc?
Created attachment 355237 [details] [review] webvttenc: Change src pad template to application/x-subtitle-vtt Use consistent mime-type with subparse element for webvtt format
commit 00cf833c95c7531017f3b985ddc7cb648a795025 Author: Seungha Yang <sh.yang@lge.com> Date: Mon Jul 10 16:39:49 2017 +0900 webvttenc: Change src pad template to application/x-subtitle-vtt Use consistent mime-type with subparse element for webvtt format https://bugzilla.gnome.org/show_bug.cgi?id=784715 commit a218a2a1af13c75b33a53c209ae25e9eb6a5509f Author: Seungha Yang <sh.yang@lge.com> Date: Sun Jul 9 14:34:21 2017 +0900 dashdemux: Add support webvtt subtitle stream Enable exposing webvtt subtitle streams. https://bugzilla.gnome.org/show_bug.cgi?id=784715