After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784715 - dashdemux: Add support webvtt subtitle stream
dashdemux: Add support webvtt subtitle stream
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-09 05:38 UTC by Seungha Yang
Modified: 2017-07-18 07:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
dashdemux: Add support webvtt subtitle stream (1.67 KB, patch)
2017-07-09 05:39 UTC, Seungha Yang
committed Details | Review
webvttenc: Change src pad template to application/x-subtitle-vtt (1.51 KB, patch)
2017-07-10 07:49 UTC, Seungha Yang
committed Details | Review

Description Seungha Yang 2017-07-09 05:38:05 UTC
Enable exposing webvtt subtitle streams.
Comment 1 Seungha Yang 2017-07-09 05:39:11 UTC
Created attachment 355203 [details] [review]
dashdemux: Add support webvtt subtitle stream

Sample stream:
https://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd
Comment 2 Sebastian Dröge (slomo) 2017-07-10 07:06:36 UTC
Review of attachment 355203 [details] [review]:

::: ext/dash/gstmpdparser.c
@@ +5750,3 @@
     return "audio/x-m4a";
+  } else if (strcmp (mimeType, "text/vtt") == 0) {
+    return "application/x-subtitle-vtt";

webvttenc from gst-plugins-bad uses "text/vtt"
Comment 3 Seungha Yang 2017-07-10 07:12:25 UTC
(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 355203 [details] [review] [review]:
> 
> ::: ext/dash/gstmpdparser.c
> @@ +5750,3 @@
>      return "audio/x-m4a";
> +  } else if (strcmp (mimeType, "text/vtt") == 0) {
> +    return "application/x-subtitle-vtt";
> 
> webvttenc from gst-plugins-bad uses "text/vtt"

webvttenc seems to encoder element but we need to subparse element to parse it.

Factory Details:
  Rank                     primary (256)
  Long-name                Subtitle parser
  Klass                    Codec/Parser/Subtitle
  Description              Parses subtitle (.sub) files into text streams
....

Pad Templates:
  SINK template: 'sink'
    Availability: Always
    Capabilities:
      application/x-subtitle
      application/x-subtitle-sami
      application/x-subtitle-tmplayer
      application/x-subtitle-mpl2
      application/x-subtitle-dks
      application/x-subtitle-qttext
      application/x-subtitle-lrc
      *application/x-subtitle-vtt*
Comment 4 Sebastian Dröge (slomo) 2017-07-10 07:24:01 UTC
Comment on attachment 355203 [details] [review]
dashdemux: Add support webvtt subtitle stream

Ah great, inconsistencies :) Can you also provide a patch for webvttenc?
Comment 5 Seungha Yang 2017-07-10 07:49:45 UTC
Created attachment 355237 [details] [review]
webvttenc: Change src pad template to application/x-subtitle-vtt

Use consistent mime-type with subparse element for webvtt format
Comment 6 Edward Hervey 2017-07-18 07:46:16 UTC
commit 00cf833c95c7531017f3b985ddc7cb648a795025
Author: Seungha Yang <sh.yang@lge.com>
Date:   Mon Jul 10 16:39:49 2017 +0900

    webvttenc: Change src pad template to application/x-subtitle-vtt
    
    Use consistent mime-type with subparse element for webvtt format
    
    https://bugzilla.gnome.org/show_bug.cgi?id=784715

commit a218a2a1af13c75b33a53c209ae25e9eb6a5509f
Author: Seungha Yang <sh.yang@lge.com>
Date:   Sun Jul 9 14:34:21 2017 +0900

    dashdemux: Add support webvtt subtitle stream
    
    Enable exposing webvtt subtitle streams.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=784715