After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784681 - rtspsrc: reject segment seeks
rtspsrc: reject segment seeks
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-08 00:23 UTC by Mathieu Duponchelle
Modified: 2018-03-27 13:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtspsrc: reject segment seeks (1.02 KB, patch)
2017-07-08 00:23 UTC, Mathieu Duponchelle 		none Details | Review
rtspsrc: reject segment seeks (1.07 KB, patch)
2017-10-12 18:36 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2017-07-08 00:23:08 UTC 
It would be nice to handle it in the future, but for now we don't
so let's be honest about it.
Comment 1 Mathieu Duponchelle 2017-07-08 00:23:12 UTC 
Created attachment 355134 [details] [review]
rtspsrc: reject segment seeks
Comment 2 Thibault Saunier 2017-07-09 01:32:49 UTC 
Review of attachment 355134 [details] [review]:

Otherwise lgtm.

::: gst/rtsp/gstrtspsrc.c
@@ +2283,3 @@
+invalid_flags:
+  {
+    GST_WARNING_OBJECT (src, "Unsupported seek flags");

Be more precise about the problem in the warning?
Comment 3 Mathieu Duponchelle 2017-10-12 18:36:28 UTC 
Created attachment 361446 [details] [review]
rtspsrc: reject segment seeks
Comment 4 Tim-Philipp Müller 2018-01-29 18:55:26 UTC 
Why not make it explicit and say "Segment seek not supported." or such?

In any case, can we get this in in some form?
Comment 5 Mathieu Duponchelle 2018-03-26 19:14:11 UTC 
Attachment 361446 [details] pushed as 893d39c - rtspsrc: reject segment seeks