After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784656 - audioaggregator: return gboolean in set_sink_caps
audioaggregator: return gboolean in set_sink_caps
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-07 15:48 UTC by Mathieu Duponchelle
Modified: 2017-10-12 19:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
audioaggregator: return gboolean in set_sink_caps (1.71 KB, patch)
2017-07-07 15:48 UTC, Mathieu Duponchelle 		reviewed Details | Review

Description Mathieu Duponchelle 2017-07-07 15:48:09 UTC 
Let callers decide what to do when info_from_caps fails.
Comment 1 Mathieu Duponchelle 2017-07-07 15:48:12 UTC 
Created attachment 355100 [details] [review]
audioaggregator: return gboolean in set_sink_caps
Comment 2 Nicolas Dufresne (ndufresne) 2017-07-07 17:43:37 UTC 
Can't you put that patch with some other patch using it ? A bug per patch hides the intention in my opinion.
Comment 3 Olivier Crête 2017-07-07 17:44:39 UTC 
Review of attachment 355100 [details] [review]:

It should always be valid at this point, because it should have been validated through the static template which should have all of the required fields.
Comment 4 Mathieu Duponchelle 2017-10-12 19:05:16 UTC 
This is obsolete, API has changed since then