GNOME Bugzilla – Bug 784654
g-s-d always adds a "us" layout
Last modified: 2017-07-17 13:05:00 UTC
Hello, While looking at the bug #780039, I saw that the keyboard plugin is always adding the "us" layout. Is there any reasons for that? If the default machine layout is defined in localed, I don't see a reason to do so. Do I miss something?
Apparently the original reason of this is bug #697597
Created attachment 355120 [details] [review] Only add the "us" layout if the machine default cannot be determined Currently, the "us" keyboard layout is added in almost all the cases, this should only be necessary if the default layout of the machine cannot be determined.
Review of attachment 355120 [details] [review]: I agree with the code change and it looks good but the commit message needs to be improved: 1. prefix the summary with "keyboard:" 2. "machine default" isn't really correct, you should mention "system config" 3. you should mention that this is only about empty user configurations (which is far from "almost all the cases")
Is this a recent regression? I noticed that after running gnome-initial-setup in F26, my keyboard layout was set to English (US) even though I had selected a different layout on the keyboard page. It added my selected layout as a new secondary layout, leaving English (US) as primary. It should have deleted all layouts except my selected layout, because I did not select English (US). Is that this bug, or is that a different bug?
Created attachment 355394 [details] [review] keyboard: Only add the "us" layout if the system config cannot be determined Currently, the "us" keyboard layout is always added the first time the user is login in, this should only be necessary if the system configured layout cannot be determined.
(In reply to Michael Catanzaro from comment #4) > Is this a recent regression? > > I noticed that after running gnome-initial-setup in F26, my keyboard layout > was set to English (US) even though I had selected a different layout on the > keyboard page. It added my selected layout as a new secondary layout, > leaving English (US) as primary. It should have deleted all layouts except > my selected layout, because I did not select English (US). Is that this bug, > or is that a different bug? definitely not this one as this only applies when a user account has zero input sources configured when g-s-d starts up. regarding what you describe, see https://git.gnome.org/browse/gnome-initial-setup/commit/?id=a6b0132193d1c4031035d4d412285a488dfaf2a6 and https://git.gnome.org/browse/gnome-initial-setup/commit/?id=c76336be6e274908f303a35715f8ce9230a9d137
Review of attachment 355394 [details] [review]: looks good, thanks
Attachment 355394 [details] pushed as d68ef6a - keyboard: Only add the "us" layout if the system config cannot be determined