After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784620 - keyboard: Special-case disabling of multi-bindings shortcuts
keyboard: Special-case disabling of multi-bindings shortcuts
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
unspecified
Other All
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-06 15:06 UTC by Florian Müllner
Modified: 2017-07-25 00:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Special-case disabling of multi-bindings shortcuts (2.37 KB, patch)
2017-07-06 15:06 UTC, Florian Müllner 		none Details | Review
keyboard: Special-case disabling of multi-bindings shortcuts (1.91 KB, patch)
2017-07-10 17:44 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-07-06 15:06:41 UTC 
See patch.
Comment 1 Florian Müllner 2017-07-06 15:06:47 UTC 
Created attachment 355021 [details] [review]
keyboard: Special-case disabling of multi-bindings shortcuts

For shortcuts that support multiple bindings, the disabled state is
expressed as an empty list rather than a list with a single empty
element. While the latter certainly works as expected as far as the
actual keybinding is concerned, the shortcut will show up as modified
even if it is disabled by default. Explicitly setting bindings to the
empty list when a shortcut is disabled fixes this.
Comment 2 Florian Müllner 2017-07-10 17:44:28 UTC 
Created attachment 355287 [details] [review]
keyboard: Special-case disabling of multi-bindings shortcuts

Rebased to master
Comment 3 Georges Basile Stavracas Neto 2017-07-25 00:43:08 UTC 
Review of attachment 355287 [details] [review]:

Nice catch, looks good.
Comment 4 Georges Basile Stavracas Neto 2017-07-25 00:44:38 UTC 
Attachment 355287 [details] pushed as 796981d - keyboard: Special-case disabling of multi-bindings shortcuts