After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784615 - gtkimcontextsimple.c: Fix build on X11-free systems
gtkimcontextsimple.c: Fix build on X11-free systems
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Input Methods
3.91.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-07-06 14:33 UTC by Quentin "Sardem FF7" Glidic
Modified: 2018-03-19 13:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to limit X11_DATA_PREFIX usage to X11 (1.12 KB, patch)
2017-07-06 14:49 UTC, Quentin "Sardem FF7" Glidic 		committed Details | Review

Description Quentin "Sardem FF7" Glidic 2017-07-06 14:33:49 UTC 
Currently, you cannot build GTK+ with the Wayland backend only.

The issue is that https://bugzilla.gnome.org/show_bug.cgi?id=757984 got an incomplete fix. X11 is *not* always available if Wayland is so the introduced check is wrong.
Comment 1 Quentin "Sardem FF7" Glidic 2017-07-06 14:49:57 UTC 
Created attachment 355017 [details] [review]
Patch to limit X11_DATA_PREFIX usage to X11
Comment 2 Daniel Boles 2017-08-05 23:59:43 UTC 
Let's double-check with the original author :)
Comment 3 Fan, Chun-wei 2017-08-07 02:41:20 UTC 
Hi,

I think I am good with this patch, though it was originally intended for the Windows side of things.

With blessings, and cheers!
Comment 4 Quentin "Sardem FF7" Glidic 2018-03-16 09:50:28 UTC 
Is this patch good for pushing? Should I resubmit via Gitlab?
Comment 5 Daniel Boles 2018-03-16 09:55:40 UTC 
Comment on attachment 355017 [details] [review]
Patch to limit X11_DATA_PREFIX usage to X11

It got reviewed above, so I think you're safe to go ahead and rebase/push to master.
Comment 6 Marc-Antoine Perennou 2018-03-19 13:41:10 UTC 
Review of attachment 355017 [details] [review]:

Pushed as f431e28ce36a1672bddc0661bcdff129304037d0