After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784608 - missing "nothing found" message when search for a project
missing "nothing found" message when search for a project
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-06 10:03 UTC by medeoTL
Modified: 2017-07-11 20:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Show 'no projects found' if there is no searchresult (3.33 KB, patch)
2017-07-11 19:02 UTC, Günther Wutz 		none Details | Review
Changed positioning of 'no projects' (3.49 KB, patch)
2017-07-11 20:33 UTC, Günther Wutz 		committed Details | Review

Description medeoTL 2017-07-06 10:03:48 UTC 
How to reproduce:

launch Builder and on the first window that open (Select a project) make a search that doesn't have a match with existing project

actual behaviour: nothing is displayed

expected behaviour: show a message that say that nothing was found.
Comment 1 Christian Hergert 2017-07-07 10:27:46 UTC 
Seems reasonable
Comment 2 Günther Wutz 2017-07-11 19:02:59 UTC 
Created attachment 355342 [details] [review]
Show 'no projects found' if there is no searchresult
Comment 3 Christian Hergert 2017-07-11 20:27:08 UTC 
Review of attachment 355342 [details] [review]:

If you set "vexpand" to true and "valign" to center does the empty state get placed in the middle? I think that would be preferred if possible. Other than that, looks good!
Comment 4 Günther Wutz 2017-07-11 20:33:52 UTC 
Created attachment 355356 [details] [review]
Changed positioning of 'no projects'

Added your suggestion. If the screen is fullscreen it feels a little bit weird (only subjective feeling)
Comment 5 Christian Hergert 2017-07-11 20:37:25 UTC 
Looks good, thanks!