After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784605 - ahcsrc: adjustable 'display-orientation' property
ahcsrc: adjustable 'display-orientation' property
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other other
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-06 07:48 UTC by Justin Kim
Modified: 2018-11-03 14:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ahcsrc: Make 'display-orientation' property writable (3.99 KB, patch)
2017-07-06 07:56 UTC, Justin Kim
none Details | Review

Description Justin Kim 2017-07-06 07:48:30 UTC
Without compensation of the orientation degrees, 'ahcsrc' displays upside-down screen when the android device is rotated left at 90 degrees. This compensation value is available from the android developer site[0].

I couldn't find a good way to set this value in Java-side while 'ahcsrc' is working so I added a JNI function which was omitted before.

[0] https://developer.android.com/reference/android/hardware/Camera.html#setDisplayOrientation(int)
Comment 1 Justin Kim 2017-07-06 07:56:56 UTC
Created attachment 355007 [details] [review]
ahcsrc: Make 'display-orientation' property writable
Comment 2 Nicolas Dufresne (ndufresne) 2017-07-06 14:10:02 UTC
I thought this was read-only and you had to compensate when displaying (e.g. in GL) ?
Comment 3 Justin Kim 2017-07-07 00:06:32 UTC
(In reply to Nicolas Dufresne (stormer) from comment #2)
> I thought this was read-only and you had to compensate when displaying (e.g.
> in GL) ?

Yes, but in recording situation(e.g filesink), can I still handle the orientation in sink?
Comment 4 Nicolas Dufresne (ndufresne) 2017-07-07 00:26:36 UTC
I was asking this question as I thought it was not portable (not all phone would work  with a property). I'm glad if this is wrong.

Note that you can always correct the orientation in sw using videoclip, or in GL using glvideoflip. Both have an automatic mode that rely on the orientation meta.
Comment 5 Justin Kim 2017-07-10 02:34:40 UTC
I got your point. Although 'setDisplayOrientation' is defined, it doesn't guarantee it will work for all device. In that case, 'orientation' property will have default value.
Let me try to use meta.
Comment 6 GStreamer system administrator 2018-11-03 14:10:38 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/579.