After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784598 - Build mozjs with consistent set of patches (jhbuild, continuous, flatpak)
Build mozjs with consistent set of patches (jhbuild, continuous, flatpak)
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other All
: Normal normal
: ---
Assigned To: Philip Chimento
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2017-07-06 04:33 UTC by Philip Chimento
Modified: 2020-11-11 18:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for JHbuild (3.24 and 3.26 modulesets) (65.26 KB, patch)
2017-07-06 04:56 UTC, Philip Chimento
none Details | Review
Patch for Flatpak manifest (should be applied both to master and gnome-3-24) (41.91 KB, patch)
2017-07-06 05:21 UTC, Philip Chimento
none Details | Review
Patch for Continuous (36.17 KB, patch)
2017-07-06 05:31 UTC, Philip Chimento
rejected Details | Review
Patch for JHbuild (3.24 and 3.26 modulesets) (39.31 KB, patch)
2017-07-17 23:02 UTC, Philip Chimento
none Details | Review
core-deps-3.24,26: Build mozjs38 from github repo (37.94 KB, patch)
2017-07-18 06:46 UTC, Philip Chimento
none Details | Review

Description Philip Chimento 2017-07-06 04:33:25 UTC
I'd like to collect all the patches that I use for the various mozjs versions in one git repository, so that I only have to update them once instead of separately on JHbuild, Continuous, and the org.gnome.Platform Flatpak manifest.

This can also serve as a guide to downstream GNOME distributors as to what patches to include on their distro's version of mozjs, and as a guide to SpiderMonkey upstream as to what patches are needed for backporting to their ESR versions.
Comment 1 Philip Chimento 2017-07-06 04:56:17 UTC
Created attachment 355000 [details] [review]
Patch for JHbuild (3.24 and 3.26 modulesets)

This makes it easier to make sure that we are using the same patches
everywhere in GNOME: in JHbuild, in Continuous, and in the Flatpak
runtime.
Comment 2 Philip Chimento 2017-07-06 05:21:23 UTC
Created attachment 355001 [details] [review]
Patch for Flatpak manifest (should be applied both to master and gnome-3-24)

This makes it easier to make sure that we are using the same patches
everywhere in GNOME: in JHbuild, in Continuous, and in the Flatpak
runtime.
Comment 3 Philip Chimento 2017-07-06 05:31:08 UTC
Created attachment 355003 [details] [review]
Patch for Continuous

This makes it easier to make sure that we are using the same patches
everywhere in GNOME: in JHbuild, in Continuous, and in the Flatpak
runtime.
Comment 4 Philip Chimento 2017-07-10 20:41:28 UTC
@jjardon, cc'ing you for the release team - who should I talk to about this?
Comment 5 Philip Chimento 2017-07-15 22:21:13 UTC
Any feedback on these patches? I am going to go ahead and commit mozjs52 to Continuous this weekend so that I can merge my mozjs52 branch and release GJS for the unstable .4 release without Continuous breaking. I'll be following the style of the mozjs38 Continuous patch attached here.
Comment 6 Philip Chimento 2017-07-15 22:35:50 UTC
Review of attachment 355003 [details] [review]:

Oops, missed a few things that I noticed when adding mozjs52.

::: manifest.json
@@ +909,3 @@
 				 "--enable-installed-tests"]},
 
+        {"src": "git:https://github.com/ptomato/mozjs38.git",

Should be mozjs.git

@@ -913,3 @@
          "component": "minimal",
-         "checksum": "01994c758174bc173bcf4960f05ecb4da21014f09641a63b2952bbf9eeaa8b5c",
-         "patches": ["mozjs38-buildapi.patch",

We actually still need the buildapi patch, since I don't think this manifest supports "source-subdir" like jhbuild does
Comment 7 Emmanuele Bassi (:ebassi) 2017-07-16 12:32:08 UTC
Build is broken on Continuous:

ERROR: Could not find autoconf 2.13
ob: pid 2 exited with code 1

Log: http://build.gnome.org/continuous/buildmaster/builds/2017/07/16/10/build/log-mozjs52.txt
Comment 8 Philip Chimento 2017-07-17 23:02:49 UTC
Created attachment 355793 [details] [review]
Patch for JHbuild (3.24 and 3.26 modulesets)

This makes it easier to make sure that we are using the same patches
everywhere in GNOME: in JHbuild, in Continuous, and in the Flatpak
runtime.
Comment 9 Philip Chimento 2017-07-17 23:15:56 UTC
Review of attachment 355003 [details] [review]:

This isn't needed anymore, since I added mozjs52 to Continuous today and will remove mozjs38 after the GJS release.
Comment 10 Philip Chimento 2017-07-17 23:17:41 UTC
Removed the blockage on 784196, since mozjs52 is now added to Continuous and JHbuild.
Comment 11 Philip Chimento 2017-07-18 06:46:33 UTC
Created attachment 355800 [details] [review]
core-deps-3.24,26: Build mozjs38 from github repo

This makes it easier to make sure that we are using the same patches
everywhere in GNOME: in JHbuild, in Continuous, and in the Flatpak
runtime.
Comment 12 Christoph Reiter (lazka) 2020-11-11 18:31:14 UTC
I assume this particular bug is no longer relevant, so closing.