GNOME Bugzilla – Bug 784592
adaptivedemux: Set connection-speed value as current download rate if set
Last modified: 2018-05-28 14:04:06 UTC
Created attachment 354986 [details] [review] hlsdemux: Return connection-speed value as bitrate if set hlsdemux: Return connection-speed value as bitrate if set If connection-speed property has been set, this value should be returned as the bitrate instead of the current download rate.
Comment on attachment 354986 [details] [review] hlsdemux: Return connection-speed value as bitrate if set Shouldn't this be rather done at the adaptivedemux layer? That's where the property comes from.
Created attachment 355238 [details] [review] adaptivedemux: Set connection-speed value as current download rate if set adaptivedemux: Set connection-speed value as current download rate if set If connection-speed property is in use, this value should be used as the current download rate.
Thanks for your review. As you've suggested, I've updated the changes to be done in the adaptivedemux. The current_download_rate is checked in hlsdemux - gst_hls_demux_get_bitrate(), and if a fixed connection-speed is in use, it should return the fixed value so that the proper bitrate playlist is maintained.
Created attachment 355312 [details] [review] adaptivedemux: Set connection-speed value as current download rate if set
Thanks ! Reworded the commit message a tiny bit to make it 100% clear why that change is needed. Attachment 355312 [details] pushed as 9992564 - adaptivedemux: Set connection-speed value as current download rate if set