After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784562 - "Printer Details" dialog has no title bar, no "OK", "Cancel", and "Close" button, requires ESC key to close
"Printer Details" dialog has no title bar, no "OK", "Cancel", and "Close" but...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
3.22.x
Other Linux
: Normal major
: ---
Assigned To: Felipe Borges
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-05 18:10 UTC by Till Kamppeter
Modified: 2017-10-04 08:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
HighContrast: don't select .titlebar when is an headerbar (17.78 KB, patch)
2017-09-22 14:54 UTC, Marco Trevisan (Treviño)
committed Details | Review
HighContrast: set min-height for headerbars (4.99 KB, patch)
2017-09-22 14:54 UTC, Marco Trevisan (Treviño)
committed Details | Review

Description Till Kamppeter 2017-07-05 18:10:13 UTC
When I click on the Gear button in the entry of a print queue and then click "Printer Details" in the pop-up menu, I get a dialog with several options and buttons, but the dialog has no title bar (which would have a close button at the upper left) and no "OK", "Cancel", or "Close" button. They only way to close this dialog is to press the ESC key on the keyboard.
Comment 1 Felipe Borges 2017-07-10 14:05:06 UTC
In which distro/desktop-environment and version are you experiencing the issue?

The dialog uses the client-side-decorations show-close-button property to present the [X] in the top right corner, so I suspect it might be a window decoration issue.
Comment 2 Till Kamppeter 2017-07-10 14:15:47 UTC
It is Ubuntu Artful (upcoming 17.10) with GNOME 3.24.2.

Window decorations (top bar) are completely missing on this dialog, whereas the dialog for the printer options has the top bar and has also a "Close" button on the lower right.
Comment 3 Michael Catanzaro 2017-07-20 21:17:47 UTC
(In reply to Till Kamppeter from comment #2)
> It is Ubuntu Artful (upcoming 17.10) with GNOME 3.24.2.

Do you have any downstream patches to this dialog in Ubuntu? We definitely do not have this problem upstream.
 
> Window decorations (top bar) are completely missing on this dialog, whereas
> the dialog for the printer options has the top bar and has also a "Close"
> button on the lower right.

The Close button should not be there. That's a bug. The obvious difference between these dialogs is the printer options dialog is still not using a header bar. We should fix that.
Comment 4 Sebastien Bacher 2017-08-07 23:14:26 UTC
> Do you have any downstream patches to this dialog in Ubuntu? We definitely do not have this problem upstream.

It seems theme dependent, adwaita works but I just tried on a fedora 26 iso and using high contrast you get the same issue...
Comment 5 Michael Catanzaro 2017-08-07 23:28:51 UTC
Wow that's pretty wild.
Comment 6 P-I H 2017-08-10 06:13:24 UTC
It also happens in Ubuntu Artful with
gnome-control-center 3.25.90-0ubuntu0-artful1
gnome-shell 3.25.4-0ubuntu0-artful2. 
theme is Ambiance and icons are Ubuntu-mono-dark
Comment 7 Sebastien Bacher 2017-08-21 10:05:56 UTC
the bug has been reported on launchpad https://bugs.launchpad.net/gnome-control-center/+bug/1712011

screenshot showing the issue
https://launchpadlibrarian.net/334020505/Screenshot%20from%202017-08-20%2020-22-10.png
Comment 8 Sebastien Bacher 2017-09-20 08:37:41 UTC
that's still an issue in GNOME 3.26
Comment 9 Jeremy Bicha 2017-09-21 11:48:29 UTC
When I use the High Contrast theme, I get this console warning:

(gnome-control-center): Gtk-WARNING **: Negative content height -11 (allocation 1, extents 6x6) while allocating gadget (node button, owner GtkButton)

When I use Ambiance, I get this warning:
(gnome-control-center): Gtk-WARNING **: Negative content height -1 (allocation 1, extents 1x1) while allocating gadget (node button, owner GtkButton)

No warning when using Adwaita where the titlebar is display for this dialog.
Comment 10 Marco Trevisan (Treviño) 2017-09-22 14:54:36 UTC
Created attachment 360264 [details] [review]
HighContrast: don't select .titlebar when is an headerbar
Comment 11 Marco Trevisan (Treviño) 2017-09-22 14:54:43 UTC
Created attachment 360265 [details] [review]
HighContrast: set min-height for headerbars
Comment 12 Matthias Clasen 2017-10-04 02:26:52 UTC
Attachment 360264 [details] pushed as b437172 - HighContrast: don't select .titlebar when is an headerbar
Attachment 360265 [details] pushed as c91a4f3 - HighContrast: set min-height for headerbars
Comment 13 Daniel Boles 2017-10-04 06:22:05 UTC
I wonder how the former of these patches interacts with Bug 769877