After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784547 - Cannot open url's using touchscreen
Cannot open url's using touchscreen
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-05 13:31 UTC by Thomas Pointhuber
Modified: 2017-11-17 00:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
chatView: Simplify context menu handling (1.51 KB, patch)
2017-11-17 00:23 UTC, Florian Müllner 		committed Details | Review
buttonTag: Add ::popup-menu signal (1.85 KB, patch)
2017-11-17 00:23 UTC, Florian Müllner 		committed Details | Review
buttonTag: Remove event signals (2.87 KB, patch)
2017-11-17 00:23 UTC, Florian Müllner 		committed Details | Review
buttonTag: Use event controller (3.00 KB, patch)
2017-11-17 00:23 UTC, Florian Müllner 		committed Details | Review

Description Thomas Pointhuber 2017-07-05 13:31:00 UTC 
Using a touchscreen, I cannot open url's from the chat by clicking onto them. Using the mouse work's as expected.
Comment 1 Florian Müllner 2017-11-17 00:22:38 UTC 
I'm attending a hackfest where I finally got a chance to get my hands (read: fingers) on a touchscreen to look into this. Patches coming ...
Comment 2 Florian Müllner 2017-11-17 00:23:09 UTC 
Created attachment 363870 [details] [review]
chatView: Simplify context menu handling

GTK+ added dedicated API for popping up a menu at the pointer location
a while ago, use that to bring up the context menu instead of the now
deprecated generic function.
Comment 3 Florian Müllner 2017-11-17 00:23:13 UTC 
Created attachment 363871 [details] [review]
buttonTag: Add ::popup-menu signal

Button tags are currently broken on touch devices, as we rely on button
press and release events. In order to fix that, it makes sense to stop
exposing the events directly, and instead add an API that hides the event
nitty-gritty.
Comment 4 Florian Müllner 2017-11-17 00:23:18 UTC 
Created attachment 363872 [details] [review]
buttonTag: Remove event signals

Those are now unused, and will get in the way when fixing touch
support.
Comment 5 Florian Müllner 2017-11-17 00:23:22 UTC 
Created attachment 363873 [details] [review]
buttonTag: Use event controller

Touch devices don't generate 'regular' press and release events, so
button tags are currently limited to pointer devices. Address this by
using a GtkEventController internally, to get a reasonable level of
pointer emulation.
Comment 6 Florian Müllner 2017-11-17 00:37:24 UTC 
Attachment 363870 [details] pushed as 5b97dcf - chatView: Simplify context menu handling
Attachment 363871 [details] pushed as 83b5671 - buttonTag: Add ::popup-menu signal
Attachment 363872 [details] pushed as 0660ac7 - buttonTag: Remove event signals
Attachment 363873 [details] pushed as 1ed652a - buttonTag: Use event controller