After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784539 - vulkan: Fails to build when only one WSI enabled
vulkan: Fails to build when only one WSI enabled
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-05 08:26 UTC by Jussi Kukkonen
Modified: 2017-07-10 14:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
vkdisplay: Use ifdef for platform specific defines (1005 bytes, patch)
2017-07-05 08:26 UTC, Jussi Kukkonen
committed Details | Review
vulkan: Use the generated version of vkconfig.h (1.90 KB, patch)
2017-07-05 08:27 UTC, Jussi Kukkonen
committed Details | Review

Description Jussi Kukkonen 2017-07-05 08:26:14 UTC
Created attachment 354910 [details] [review]
vkdisplay: Use ifdef for platform specific defines

Build fails in ext/vulkan/xcb and ext/vulkan/wayland when:
 * building from tarball
 * building out-of-tree
 * Only one WSI integration (xcb or wayland) is enabled by configure.ac
This is because vkconfig.h from source directory gets used instead of the generated one.

Also, vkdisplay.c fails to build in general if only one WSI integration is enabled.

Attaching a couple of patches. Maybe I should have tried to change vkconfig.h to always generate (and not ship in tarball) but current patch just fixes the issue following the current design.
Comment 1 Jussi Kukkonen 2017-07-05 08:27:19 UTC
Created attachment 354911 [details] [review]
vulkan: Use the generated version of vkconfig.h
Comment 2 Matthew Waters (ystreet00) 2017-07-10 14:43:29 UTC
commit 97b0085c489a475ac498c6bddf81131a5197d75d (HEAD -> master)
Author: Jussi Kukkonen <jussi.kukkonen@intel.com>
Date:   Wed Jul 5 11:07:05 2017 +0300

    vulkan: Use the generated version of vkconfig.h
    
    Build fails in ext/vulkan/xcb and ext/vulkan/wayland when:
    * building from tarball
    * building out-of-tree
    * Only one WSI integration (xcb or wayland) is enabled by configure.ac
    This is because vkconfig.h from source directory gets used instead
    of the generated one.
    
    Add the correct build directory to "-I". Use angle bracket
    include in vkapi.h so that it actually looks in the include search
    path instead of defaulting to the same (source tree) directory.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=784539

commit 9c6d36984f11edf7a9dacca96488a64c6478444b
Author: Jussi Kukkonen <jussi.kukkonen@intel.com>
Date:   Wed Jul 5 11:00:42 2017 +0300

    vkdisplay: Use ifdef for platform specific defines
    
    VK_KHR_*_SURFACE_EXTENSION_NAME are only available when corresponding
    WSI is enabled.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=784539