After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784479 - omxvideodec: increase the minimum number of allocated buffers
omxvideodec: increase the minimum number of allocated buffers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-03 14:58 UTC by Guillaume Desmottes
Modified: 2017-07-03 15:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
omxvideodec: increase the minimum number of allocated buffers (1.50 KB, patch)
2017-07-03 14:58 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2017-07-03 14:58:34 UTC 
.
Comment 1 Guillaume Desmottes 2017-07-03 14:58:52 UTC 
Created attachment 354843 [details] [review]
omxvideodec: increase the minimum number of allocated buffers

Ensure that enough buffers are allocated by adding up component's own
minimal plus the number of buffers requested by downstream.
This should prevent buffers starvation problem if downstream elements
are holding some of the buffers they required.

Also simplify the check on the maximum on buffers. What we actually care
about is to make sure the pool can hold the minimum of required buffers.
Comment 2 Nicolas Dufresne (ndufresne) 2017-07-03 15:05:10 UTC 
Review of attachment 354843 [details] [review]:

Looks good to me, this is what we do elsewhere too.
Comment 3 Nicolas Dufresne (ndufresne) 2017-07-03 15:05:37 UTC 
Attachment 354843 [details] pushed as a380511 - omxvideodec: increase the minimum number of allocated buffers