After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784461 - Allow "udp6" & "tcp6" protocols to pass through
Allow "udp6" & "tcp6" protocols to pass through
Status: RESOLVED DUPLICATE of bug 731620
Product: NetworkManager
Classification: Platform
Component: VPN: openvpn
unspecified
Other All
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-07-03 03:23 UTC by Jeremy Bicha
Modified: 2017-09-26 08:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Allow "udp6" & "tcp6" protocols to pass through (1.48 KB, patch)
2017-07-03 03:23 UTC, Jeremy Bicha 		none Details | Review

Description Jeremy Bicha 2017-07-03 03:23:31 UTC 
Ubuntu has been carrying this patch for a while.

https://launchpad.net/bugs/777161
Comment 1 Jeremy Bicha 2017-07-03 03:23:34 UTC 
Created attachment 354812 [details] [review]
Allow "udp6" & "tcp6" protocols to pass through
Comment 2 Beniamino Galvani 2017-07-04 10:06:01 UTC 
(In reply to Jeremy Bicha from comment #1)
> Created attachment 354812 [details] [review] [review]
> Allow "udp6" & "tcp6" protocols to pass through

How about accepting also udp4 and tcp4? i.e.: 

-   if (proto && strcmp (proto, "udp") && strcmp (proto, "tcp") && strcmp (proto, "udp6") && strcmp (proto, "tcp6"))
+   if (!NM_IN_STRSET (proto, NULL, "udp", "udp4", "udp6", "tcp", "tcp4", "tcp6"))

Also, I think we should always add the '-client' suffix to tcp proto. Probably we should do something like:

	if (NM_IN_STRSET (proto, "udp", "udp4", "udp6"))
 		add_openvpn_arg (args, proto);
 	else if (nm_streq (proto, "tcp"))
 		add_openvpn_arg (args, "tcp-client");
	else if (nm_streq (proto, "tcp4"))
		add_openvpn_arg (args, "tcp4-client");
	else if (nm_streq (proto, "tcp6"))
		add_openvpn_arg (args, "tcp6-client");

What do you think?
Comment 3 Thomas Haller 2017-09-26 08:58:27 UTC 
Fixed by https://git.gnome.org/browse/network-manager-openvpn/commit/?id=3c5c7efba75ffd121be3b0ac179c36ca9aa772b0 and bug 731620.

*** This bug has been marked as a duplicate of bug 731620 ***