After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784394 - Don't throw away text prematurely
Don't throw away text prematurely
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2017-06-30 17:47 UTC by Matthias Clasen
Modified: 2017-07-10 11:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't throw away text prematurely (1.00 KB, patch)
2017-06-30 17:47 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2017-06-30 17:47:25 UTC
When calling into cairo to render glyphs, we want
to use show_text_glyphs and pass the text along,
if the surface supports that operation. But here,
we throw the text away prematurely and end up
always end passing no text or clusters down to
cairo.
Comment 1 Matthias Clasen 2017-06-30 17:47:34 UTC
Created attachment 354745 [details] [review]
Don't throw away text prematurely
Comment 2 Matthias Clasen 2017-06-30 17:56:22 UTC
Attachment 354745 [details] pushed as b17fe9b - Don't throw away text prematurely
Comment 3 Behdad Esfahbod 2017-07-10 11:11:17 UTC
Ouch!