GNOME Bugzilla – Bug 784370
omxh264enc: typo in "periodicty-idr" property name
Last modified: 2017-07-13 12:24:14 UTC
The "periodicty-idr" property should be named ""periodicity-idr". Is it ok to change it as technically that would be an API change.
I would opt for changing it, Worst case we can reads a deprecated alias later.
Created attachment 354731 [details] [review] omxh264enc: fix typo in "periodicty-idr" property name Also fix the 'nick' of the property.
Attachment 354731 [details] pushed as 2034b26 - omxh264enc: fix typo in "periodicty-idr" property name
(In reply to Nicolas Dufresne (stormer) from comment #1) > I would opt for changing it, Worst case we can reads a deprecated alias > later. by "later" you mean after we've quietly screwed someone over by breaking their app and they've had to come to us and complain?
commit fe9cdb9b19cecab8c779ee1d207b3fd70d72f3d7 Author: Jan Schmidt <jan@centricular.com> Date: Thu Jul 13 16:40:26 2017 +1000 omxh264enc: Re-add periodicty-idr property for backward compat Retain backwards compatibility by adding a duplicate property for periodicty-idr https://bugzilla.gnome.org/show_bug.cgi?id=784370
This property was a no-op before on RPi, we fixed it a week ago, so please, have some respect, the decision was not about screwing up code and Just the fact this has effect now will likely screw up applications anyway.
A property that has no effect (on one of the gst-omx targets) is not the same as making someone's app suddenly throw g-criticals because API changed in a module that's not advertised as API-unstable. I hate these kind of small ABI breaks. The problems that cause never show up until it's too late to do something about it, and contribute to a general perception that upgrading GStreamer is risky because stuff breaks. We've advertised API stability as a feature since 2005, and it's hard but important.