After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784358 - Add npm plugin
Add npm plugin
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-06-29 18:06 UTC by Giovanni Campagna
Modified: 2017-06-30 01:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add npm plugin (7.63 KB, patch)
2017-06-29 18:06 UTC, Giovanni Campagna
none Details | Review
Add npm plugin (6.44 KB, patch)
2017-06-30 01:31 UTC, Giovanni Campagna
none Details | Review
npm: add npm build system plugin (7.12 KB, patch)
2017-06-30 01:31 UTC, Christian Hergert
committed Details | Review

Description Giovanni Campagna 2017-06-29 18:06:18 UTC
Recognizes "package.json" as a valid project file (instead of using
the directory type), and runs "npm install" while building.
Comment 1 Giovanni Campagna 2017-06-29 18:06:24 UTC
Created attachment 354703 [details] [review]
Add npm plugin
Comment 2 sébastien lafargue 2017-06-29 18:14:23 UTC
Hey, Giovanni.

Builder master branch do not use Autotools anymore as its build system but only Meson, so you can remove these bits.
Comment 3 Giovanni Campagna 2017-06-30 01:29:54 UTC
(In reply to sébastien lafargue from comment #2)
> Hey, Giovanni.
> 
> Builder master branch do not use Autotools anymore as its build system but
> only Meson, so you can remove these bits.

Botched rebase, I guess. I'll resend.
Comment 4 Giovanni Campagna 2017-06-30 01:31:07 UTC
Created attachment 354718 [details] [review]
Add npm plugin

Recognizes "package.json" as a valid project file (instead of using
the directory type), and runs "npm install" while building.
Comment 5 Christian Hergert 2017-06-30 01:31:45 UTC
Created attachment 354719 [details] [review]
npm: add npm build system plugin

Recognizes "package.json" as a valid project file (instead of using
the directory type), and runs "npm install" while building.
Comment 6 Christian Hergert 2017-06-30 01:32:50 UTC
I added a blurb to the plugin overview and make sure we copy
the .plugin file to the builddir for tests.

Attachment 354719 [details] pushed as 31b7629 - npm: add npm build system plugin