After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784357 - keyboard: Follow the usual search pattern for filtering
keyboard: Follow the usual search pattern for filtering
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
3.24.x
Other All
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-06-29 18:03 UTC by Florian Müllner
Modified: 2017-06-30 00:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Follow the usual search pattern for filtering (1.60 KB, patch)
2017-06-29 18:03 UTC, Florian Müllner 		none Details | Review
keyboard: Follow the usual search pattern for filtering (1.64 KB, patch)
2017-06-30 00:37 UTC, Georges Basile Stavracas Neto 		committed Details | Review

Description Florian Müllner 2017-06-29 18:03:49 UTC 
See patch.
Comment 1 Florian Müllner 2017-06-29 18:03:53 UTC 
Created attachment 354701 [details] [review]
keyboard: Follow the usual search pattern for filtering

Filtering on the name currently only matches the string as a whole,
not individual words as expected, for instance "home fo" and "ho fo"
should both match "Home Folder".
Comment 2 Georges Basile Stavracas Neto 2017-06-30 00:33:32 UTC 
Review of attachment 354701 [details] [review]:

One small nit. Otherwise, look good.

::: panels/keyboard/cc-keyboard-panel.c
@@ +568,3 @@
+      if (!retval)
+        break;
+    }

Nitpick: I'd be more comfortable in using an integer index.
Comment 3 Georges Basile Stavracas Neto 2017-06-30 00:37:14 UTC 
Created attachment 354717 [details] [review]
keyboard: Follow the usual search pattern for filtering

Use an integer index rather than implicit pointer maths.
Comment 4 Georges Basile Stavracas Neto 2017-06-30 00:38:07 UTC 
Attachment 354717 [details] pushed as 3910b4a - keyboard: Follow the usual search pattern for filtering