After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784353 - Warning on launching applications.
Warning on launching applications.
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
3.25.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-06-29 16:21 UTC by Hussam Al-Tayeb
Modified: 2017-07-05 15:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
st: Don't try to create shadow for empty texture (1.05 KB, patch)
2017-06-29 22:23 UTC, Florian Müllner
committed Details | Review

Description Hussam Al-Tayeb 2017-06-29 16:21:09 UTC
I see this warning in my journal when starting applications.
Jun 29 19:15:52 hades gnome-shell[28955]: _st_create_shadow_pipeline: assertion 'src_texture != NULL' failed
This warning only happens once per application after logging into Gnome.
For example, opening gedit from gnome-shell results in this warning. Closing Gedit and reopening it does not show the warning again.

However, if I close all applications and alt-f2 -> r, the warnings will start showing again.
Comment 1 Florian Müllner 2017-06-29 22:23:13 UTC
Created attachment 354710 [details] [review]
st: Don't try to create shadow for empty texture

Even though the API documentation doesn't say so, the underlying
Cogl texture of a ClutterTexture may be unset, so check for that
case to avoid a runtime warning.
Comment 2 Hussam Al-Tayeb 2017-06-30 10:33:00 UTC
Hi Florian. Thank you very much. That cleared the warning.
Comment 3 Rui Matos 2017-07-05 15:00:00 UTC
Review of attachment 354710 [details] [review]:

lgtm
Comment 4 Florian Müllner 2017-07-05 15:10:48 UTC
Attachment 354710 [details] pushed as d1c71fd - st: Don't try to create shadow for empty texture