After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784340 - data: Revert dropping gdm-shell.session
data: Revert dropping gdm-shell.session
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2017-06-29 14:16 UTC by Jeremy Bicha
Modified: 2017-06-29 16:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
data: Revert dropping gdm-shell.session (2.86 KB, patch)
2017-06-29 14:16 UTC, Jeremy Bicha 		none Details | Review
data: Add gnome-login.session (2.98 KB, patch)
2017-06-29 15:51 UTC, Jeremy Bicha 		committed Details | Review

Description Jeremy Bicha 2017-06-29 14:16:42 UTC 
The removal caused problems for Ubuntu 17.10 which does not
include gnome.session by default.

https://launchpad.net/bugs/1701243
Comment 1 Jeremy Bicha 2017-06-29 14:16:45 UTC 
Created attachment 354690 [details] [review]
data: Revert dropping gdm-shell.session
Comment 2 Jeremy Bicha 2017-06-29 14:19:41 UTC 
I think it's possible that GDM does not need every gnome-settings-daemon plugin that a full GNOME Shell session does. If someone would identify which plugins are not needed, that is another reason why this patch is a good idea.
Comment 3 Ray Strode [halfline] 2017-06-29 15:42:41 UTC 
we used to just whitelist these:

whitelisted-plugins=['a11y-keyboard', 'a11y-settings', 'background', 'clipboard', 'color', 'cursor', 'keyboard', 'media-keys', 'orientation', 'power', 'smartcard', 'sound', 'xrandr', 'xsettings']

until bug 772447
Comment 4 Jeremy Bicha 2017-06-29 15:51:18 UTC 
Created attachment 354696 [details] [review]
data: Add gnome-login.session

This reverts
https://git.gnome.org/browse/gdm/commit/?id=f66cdfcb2
and renames the session from gdm-shell to gnome-login.

The removal caused problems for Ubuntu 17.10 which does not
include gnome.session by default.

https://launchpad.net/bugs/1701243
Comment 5 Ray Strode [halfline] 2017-06-29 15:57:34 UTC 
Review of attachment 354696 [details] [review]:

feel free to push. we can do a follow up commit to trim the list.