After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784284 - unifying "Clear the entry." tooltip on Loan Repayment Calculator
unifying "Clear the entry." tooltip on Loan Repayment Calculator
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: User Interface General
git-maint
Other All
: Normal minor
: ---
Assigned To: gnucash-ui-maint
gnucash-ui-maint
Depends on:
Blocks:
 
 
Reported: 2017-06-28 13:05 UTC by Yasuaki Taniguchi
Modified: 2018-06-29 23:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
unifying string on Loan Repayment Calculator patch (50.49 KB, patch)
2017-06-28 13:05 UTC, Yasuaki Taniguchi 		none Details | Review
fincalc tooltip patch rev2 (3.04 KB, patch)
2017-07-01 03:02 UTC, Yasuaki Taniguchi 		committed Details | Review
tooltip location (39.32 KB, image/png)
2017-07-01 03:03 UTC, Yasuaki Taniguchi 		  Details

Description Yasuaki Taniguchi 2017-06-28 13:05:25 UTC 
Created attachment 354617 [details] [review]
unifying string on Loan Repayment Calculator patch

On Loan Repayment Calculator dialog, tooltip for "Clear" buttons has 2 types of string.
(1) Clear the entry
(2) Clear the entry.

This patch is unifying to (2).
Comment 1 Frank H. Ellenberger 2017-06-29 09:45:31 UTC 
Review of attachment 354617 [details] [review]:

Thank you for your work.
But 50k to change one string are heavy. Where is the string?
Can you remove the artefacts, which glade inserted?
It might be easier to use a text editor to change the string.
Comment 2 Yasuaki Taniguchi 2017-07-01 03:02:07 UTC 
A lot of lines are modified when I used glade-3.
Only 4 lines are needed to be modified.

I will attache a new patch which is modified glade file by hand.
Comment 3 Yasuaki Taniguchi 2017-07-01 03:02:55 UTC 
Created attachment 354752 [details] [review]
fincalc tooltip patch rev2
Comment 4 Yasuaki Taniguchi 2017-07-01 03:03:45 UTC 
Created attachment 354753 [details]
tooltip location
Comment 5 Frank H. Ellenberger 2017-07-27 03:42:20 UTC 
Bob, can we apply attachment 354752 [details] [review] or should it wait until you are finished?
Comment 6 Geert Janssens 2017-08-21 20:41:26 UTC 
Patch applied, thanks!
Comment 7 John Ralls 2018-06-29 23:57:33 UTC 
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=784284. Please update any external references or bookmarks.