After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784245 - Notifications list - notifications without icons are misaligned
Notifications list - notifications without icons are misaligned
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-06-27 11:18 UTC by Allan Day
Modified: 2017-07-05 16:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (76.09 KB, image/png)
2017-06-27 11:18 UTC, Allan Day 		  Details
notificationDaemon: Fix fallback icon names (1.17 KB, patch)
2017-06-29 23:14 UTC, Florian Müllner 		committed Details | Review

Description Allan Day 2017-06-27 11:18:02 UTC 
Created attachment 354558 [details]
screenshot

See the attached screenshot - some notifications don't have icons, and when they don't, the notification text doesn't have the same alignment as the others.

Both the Dropbox and Nextcloud clients seem to produce notifications without icons.

It might be best to ensure that every notification has an icon. If the sender doesn't provide one, just use a generic default, like preferences-system-notifications-symbolic or dialog-information-symbolic.
Comment 1 Florian Müllner 2017-06-29 23:14:43 UTC 
Created attachment 354716 [details] [review]
notificationDaemon: Fix fallback icon names

The gtk-dialog-* names are old and non-standard, and haven't been
provided by the default icon theme for quite a while ...
Comment 2 Rui Matos 2017-07-05 15:29:50 UTC 
Review of attachment 354716 [details] [review]:

should use the -symbolic suffix, no?
Comment 3 Florian Müllner 2017-07-05 16:21:21 UTC 
(In reply to Rui Matos from comment #2)
> should use the -symbolic suffix, no?

It doesn't really matter:
https://git.gnome.org//browse/gnome-shell-sass/tree/_common.scss#n1069
Comment 4 Rui Matos 2017-07-05 16:30:11 UTC 
Review of attachment 354716 [details] [review]:

ok then
Comment 5 Florian Müllner 2017-07-05 16:41:47 UTC 
Attachment 354716 [details] pushed as 180a897 - notificationDaemon: Fix fallback icon names