GNOME Bugzilla – Bug 784240
gnome-contacts fails to build
Last modified: 2017-07-02 23:50:03 UTC
gnome-contacts git master $ valac --version Vala 0.34.0.109-14cb5 folks-0.11.3-5.fc26.x86_64 It also fails with: $ valac --version Vala 0.36.3 folks-telepathy.vapi:33.3-33.54: error: Type and/or accessors of overriding property `Tpf.PersonaStore.personas' do not match overridden property `Folks.PersonaStore.personas': incompatible get accessor type. public override Gee.Map<string,Tpf.Persona> personas { get; } ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ folks-telepathy.vapi:33.3-33.54: error: Tpf.PersonaStore.personas: no suitable property found to override public override Gee.Map<string,Tpf.Persona> personas { get; } ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ folks-eds.vapi:46.3-46.55: error: Type and/or accessors of overriding property `Edsf.PersonaStore.personas' do not match overridden property `Folks.PersonaStore.personas': incompatible get accessor type. public override Gee.Map<string,Edsf.Persona> personas { get; } ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ folks-eds.vapi:46.3-46.55: error: Edsf.PersonaStore.personas: no suitable property found to override public override Gee.Map<string,Edsf.Persona> personas { get; } ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ folks-telepathy.vapi:33.3-33.54: error: Type and/or accessors of overriding property `Tpf.PersonaStore.personas' do not match overridden property `Folks.PersonaStore.personas': incompatible get accessor type. public override Gee.Map<string,Tpf.Persona> personas { get; } ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ folks-telepathy.vapi:33.3-33.54: error: Tpf.PersonaStore.personas: no suitable property found to override public override Gee.Map<string,Tpf.Persona> personas { get; } ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ folks-eds.vapi:46.3-46.55: error: Type and/or accessors of overriding property `Edsf.PersonaStore.personas' do not match overridden property `Folks.PersonaStore.personas': incompatible get accessor type. public override Gee.Map<string,Edsf.Persona> personas { get; } ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ folks-eds.vapi:46.3-46.55: error: Edsf.PersonaStore.personas: no suitable property found to override public override Gee.Map<string,Edsf.Persona> personas { get; } ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This was fixed in master in commit ddc7e71c5d0d113a1b46e2a89986f5a9c3ab8374. I need to do a release, but I need to fix the unit tests first, and in order to do that I need to grow some time.
Thanks for the quick reply! Could you give me a heads-up when the new release would be, so I can release gnome-contacts as well? :-)
(In reply to Niels De Graef from comment #2) > Thanks for the quick reply! Could you give me a heads-up when the new > release would be, so I can release gnome-contacts as well? :-) Sorry, I can’t give you a date. ‘When I get time’ is the best I can do. I need to find new maintainers for libfolks, because I’m doing a terrible job.
(In reply to Philip Withnall from comment #3) > (In reply to Niels De Graef from comment #2) > > Thanks for the quick reply! Could you give me a heads-up when the new > > release would be, so I can release gnome-contacts as well? :-) > > Sorry, I can’t give you a date. ‘When I get time’ is the best I can do. I > need to find new maintainers for libfolks, because I’m doing a terrible job. Oh, I didn't mean a specific date, just a notification on IRC/mail when folks builds again. Also, don't beat up yourself about it man, we all need to find a work-life combination that works. No shame in that ;-) About the work that still needs to be done: maybe you can open a bug (possibly with a WIP branch to start from) so that those who want, can help you?
(In reply to Niels De Graef from comment #4) > (In reply to Philip Withnall from comment #3) > > (In reply to Niels De Graef from comment #2) > > > Thanks for the quick reply! Could you give me a heads-up when the new > > > release would be, so I can release gnome-contacts as well? :-) > > > > Sorry, I can’t give you a date. ‘When I get time’ is the best I can do. I > > need to find new maintainers for libfolks, because I’m doing a terrible job. > Oh, I didn't mean a specific date, just a notification on IRC/mail when > folks builds again. > > Also, don't beat up yourself about it man, we all need to find a work-life > combination that works. No shame in that ;-) > > About the work that still needs to be done: maybe you can open a bug > (possibly with a WIP branch to start from) so that those who want, can help > you? After several hours of fighting valac and valadoc, I’ve released 0.11.4, containing the fix for this bug.
(In reply to Philip Withnall from comment #5) > After several hours of fighting valac and valadoc, I’ve released 0.11.4, > containing the fix for this bug. Man, you are awesome. Thanks!!