After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784225 - Build failure if HOSTNAME_PERSIST_SUSE is defined
Build failure if HOSTNAME_PERSIST_SUSE is defined
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: Distro-specific
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-06-26 17:37 UTC by Mike Gorse
Modified: 2017-06-27 07:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (2.24 KB, patch)
2017-06-26 17:42 UTC, Mike Gorse 		none Details | Review
Revised patch. (1.70 KB, patch)
2017-06-27 00:12 UTC, Mike Gorse 		none Details | Review

Description Mike Gorse 2017-06-26 17:37:53 UTC 
CONF_DHCP is referenced in nm-hostname-manager.c in a couple of places, but it is only defined in nm-settings.c.
Comment 1 Mike Gorse 2017-06-26 17:42:41 UTC 
Created attachment 354529 [details] [review]
Proposed patch.
Comment 2 Beniamino Galvani 2017-06-26 20:52:56 UTC 
Hi, thanks for the patch!

I think you can just move the 2 defines to nm-hostname-manager.c, as they are not needed in nm-settings.c.
Comment 3 Mike Gorse 2017-06-27 00:12:20 UTC 
Created attachment 354538 [details] [review]
Revised patch.

Yeah, this will work, too.