After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784204 - Drop libuuid dependency
Drop libuuid dependency
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.25.x
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks: 783234
 
 
Reported: 2017-06-26 09:29 UTC by Felipe Borges
Modified: 2017-08-23 09:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Bump Vala dep to 0.36.3 (896 bytes, patch)
2017-06-26 09:29 UTC, Felipe Borges
none Details | Review
machine: Use GLib.uuid_string_random (883 bytes, patch)
2017-06-26 09:29 UTC, Felipe Borges
committed Details | Review
build: Drop libuuid dependency (1.97 KB, patch)
2017-06-26 09:29 UTC, Felipe Borges
committed Details | Review
configure: Require glib >= 2.52 (771 bytes, patch)
2017-08-15 10:49 UTC, Debarshi Ray
committed Details | Review

Description Felipe Borges 2017-06-26 09:29:27 UTC
.
Comment 1 Felipe Borges 2017-06-26 09:29:49 UTC
Created attachment 354489 [details] [review]
build: Bump Vala dep to 0.36.3

Bump from Vala 0.36.0 to 0.36.3, so we can benefit from the
GLib uuid_string_* symbols introduced at the vala commit
https://git.gnome.org/browse/vala/commit/?id=4cab2c2 and,
this way, drop the libuuid dependency.

vala 0.36.3 is part of the GNOME 3.25.2 release.
Comment 2 Felipe Borges 2017-06-26 09:29:54 UTC
Created attachment 354490 [details] [review]
machine: Use GLib.uuid_string_random

Since GLib 2.52 we no longer need to depend on libuuid.

The uuid_string_* symbols were introduced in the Vala
vapi at version 0.36.3
Comment 3 Felipe Borges 2017-06-26 09:29:59 UTC
Created attachment 354491 [details] [review]
build: Drop libuuid dependency
Comment 4 Pavel Grunt 2017-07-03 11:33:30 UTC
Review of attachment 354489 [details] [review]:

That commit is before 0.36.0
Comment 5 Felipe Borges 2017-07-03 17:01:45 UTC
Comment on attachment 354489 [details] [review]
build: Bump Vala dep to 0.36.3

obsolete then.
Comment 6 Zeeshan Ali 2017-07-11 12:11:06 UTC
Review of attachment 354490 [details] [review]:

ack
Comment 7 Zeeshan Ali 2017-07-11 12:11:27 UTC
Review of attachment 354491 [details] [review]:

ack
Comment 8 Zeeshan Ali 2017-07-11 12:12:57 UTC
(In reply to Felipe Borges from comment #5)
> Comment on attachment 354489 [details] [review] [review]
> build: Bump Vala dep to 0.36.3
> 
> obsolete then.

Just to be clear, we already depend on the version that adds the new glib function?
Comment 9 Felipe Borges 2017-07-12 09:10:16 UTC
Thanks for reviewing.

(In reply to Zeeshan Ali (Khattak) from comment #8)
> Just to be clear, we already depend on the version that adds the new glib
> function?

Yes, it was introduced in Vala 0.35.4.

Attachment 354490 [details] pushed as 1105885 - machine: Use GLib.uuid_string_random
Attachment 354491 [details] pushed as 6df5ef2 - build: Drop libuuid dependency
Comment 10 Debarshi Ray 2017-08-15 10:49:13 UTC
Created attachment 357619 [details] [review]
configure: Require glib >= 2.52

We also need to bump the GLib requirement.
Comment 11 Felipe Borges 2017-08-21 08:23:53 UTC
Review of attachment 357619 [details] [review]:

lgtm
Comment 12 Felipe Borges 2017-08-21 08:25:02 UTC
Attachment 357619 [details] pushed as c580849 - configure: Require glib >= 2.52
Comment 13 Debarshi Ray 2017-08-23 09:27:27 UTC
Thanks, Felipe!