GNOME Bugzilla – Bug 784204
Drop libuuid dependency
Last modified: 2017-08-23 09:27:27 UTC
.
Created attachment 354489 [details] [review] build: Bump Vala dep to 0.36.3 Bump from Vala 0.36.0 to 0.36.3, so we can benefit from the GLib uuid_string_* symbols introduced at the vala commit https://git.gnome.org/browse/vala/commit/?id=4cab2c2 and, this way, drop the libuuid dependency. vala 0.36.3 is part of the GNOME 3.25.2 release.
Created attachment 354490 [details] [review] machine: Use GLib.uuid_string_random Since GLib 2.52 we no longer need to depend on libuuid. The uuid_string_* symbols were introduced in the Vala vapi at version 0.36.3
Created attachment 354491 [details] [review] build: Drop libuuid dependency
Review of attachment 354489 [details] [review]: That commit is before 0.36.0
Comment on attachment 354489 [details] [review] build: Bump Vala dep to 0.36.3 obsolete then.
Review of attachment 354490 [details] [review]: ack
Review of attachment 354491 [details] [review]: ack
(In reply to Felipe Borges from comment #5) > Comment on attachment 354489 [details] [review] [review] > build: Bump Vala dep to 0.36.3 > > obsolete then. Just to be clear, we already depend on the version that adds the new glib function?
Thanks for reviewing. (In reply to Zeeshan Ali (Khattak) from comment #8) > Just to be clear, we already depend on the version that adds the new glib > function? Yes, it was introduced in Vala 0.35.4. Attachment 354490 [details] pushed as 1105885 - machine: Use GLib.uuid_string_random Attachment 354491 [details] pushed as 6df5ef2 - build: Drop libuuid dependency
Created attachment 357619 [details] [review] configure: Require glib >= 2.52 We also need to bump the GLib requirement.
Review of attachment 357619 [details] [review]: lgtm
Attachment 357619 [details] pushed as c580849 - configure: Require glib >= 2.52
Thanks, Felipe!