After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784183 - tests/libedata-cal/test-cal-cache-utils.c needs sys/wait.h
tests/libedata-cal/test-cal-cache-utils.c needs sys/wait.h
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
3.25.x (obsolete)
Other FreeBSD
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2017-06-25 16:08 UTC by Ting-Wei Lan
Modified: 2017-06-27 12:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add missing sys/wait.h include for test-cal-cache-utils.c (742 bytes, patch)
2017-06-25 16:10 UTC, Ting-Wei Lan
reviewed Details | Review

Description Ting-Wei Lan 2017-06-25 16:08:03 UTC
tests/libedata-cal/test-cal-cache-utils.c fails to compile on FreeBSD:

/home/lantw44/gnome/source/evolution-data-server/tests/libedata-cal/test-cal-cache-utils.c:46:12: error: implicit declaration of function 'WIFEXITED' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        g_assert (WIFEXITED (exit_status));
                  ^
/home/lantw44/gnome/source/evolution-data-server/tests/libedata-cal/test-cal-cache-utils.c:47:19: error: implicit declaration of function 'WEXITSTATUS' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        g_assert_cmpint (WEXITSTATUS (exit_status), ==, 0);
                         ^
2 errors generated.

It can be easily resolved by adding '#include <sys/wait.h>'.
Comment 1 Ting-Wei Lan 2017-06-25 16:10:49 UTC
Created attachment 354421 [details] [review]
Add missing sys/wait.h include for test-cal-cache-utils.c
Comment 2 Milan Crha 2017-06-27 12:49:41 UTC
Thanks for a bug report and patch. Both missing symbols are guarded by
   #ifndef G_OS_WIN32
thus I added the same for the added #include.

Created commit 7d09861 in eds master (3.25.4+)