GNOME Bugzilla – Bug 784179
meson build port flags fixes
Last modified: 2017-06-26 10:23:25 UTC
Created attachment 354412 [details] [review] Changed gir file to be formed by variables The change allows an easier transition between api versions, if they happen, by forming the gir file name using variables in the main meson build file.
Created attachment 354413 [details] [review] Removed plugins_vala_sources variable Removed plugins_vala_sources variable which is not necessary any more.
Created attachment 354414 [details] [review] Removed duplicated po_dir definition po_dir is defined in the main meson build file and can be reused when merging translations.
Created attachment 354415 [details] [review] Use of a variable for the AppStream XML file name The name of the AppStream XML has been moved to a variable making it less error prone.
Review of attachment 354412 [details] [review]: Not that useful, but sure.
Review of attachment 354413 [details] [review]: Looks correct.
Review of attachment 354414 [details] [review]: Sure.
Review of attachment 354415 [details] [review]: If you don't change the indentation, there's only one line added and 2 changed.
Created attachment 354422 [details] [review] build: Use of a variable for the AppStream XML file name The name of the AppStream XML has been moved to a variable making it less error prone.
Review of attachment 354422 [details] [review]: Like so.
There are some subtle changes in the patch. I have changed the indentation on purpose, simply to be consistent with the whole meson port's indentation. The name of the target was also intentionally changed from 'appdata' string to appdata variable, which holds the name of the resulting file name, being consistent in addition with the rest of the meson port. However, if you consider it's better that way, feel free to change it :)
Created attachment 354495 [details] [review] Use meson to translate desktop file totem has started using meson translation capabilities for some files[0]. This patchs also uses meson's translation feature for the destkop file. [0] https://git.gnome.org/browse/totem/commit/?id=a13d42100ab3337de5050e82da81577c46cc6a64
(In reply to Iñigo Martínez from comment #10) > There are some subtle changes in the patch. I have changed the indentation > on purpose, simply to be consistent with the whole meson port's indentation. Can't say I like it. > The name of the target was also intentionally changed from 'appdata' string > to appdata variable, which holds the name of the resulting file name, being > consistent in addition with the rest of the meson port. But what does it fix/change? > However, if you consider it's better that way, feel free to change it :) The rest of the reordering I don't understand how you can justify, really. So yes, I prefer my version ;)
Created attachment 354496 [details] [review] Renamed desktop file Since the autotools removal, org.gnome.Totem.desktop.in.in.in file was unnecessary. This patch removes this file and renames org.gnome.Totem.desktop.meson to org.gnome.Totem.desktop.in.in, to denote the two steps in its generation, variable removal and translation merge, and to maintain the consistency with the rest of the files.
Created attachment 354497 [details] [review] Replaced thumbnailer template file The totem.thumbnailer.in file, which is not used any more on the meson build port, has been replaced by the meson template, whose contents were used but renaming it in order to make its filename consistent with the rest of the files.