GNOME Bugzilla – Bug 784176
Tags are exchanged between different assets on the list dialogs on the Input text area
Last modified: 2018-01-11 20:33:53 UTC
I am using extensively the tags as folders and customized and I have noted an strange effect... them are being exchanged between assets and are showed incorrectly. The steps to see this effect is a bit unusual: 1) Open the brushes dialog as list; 2) Select an 'asset 1'; 3) Create a new custom tag for this asset, e.g., 'exchange'; 4) Refresh brush the list with button; 5) The list of tags on 'asset 1' is apparently erased; 6) Select the 'asset 2' below of the 'asset 1'; 7) The tag asset showed is of previous asset, 'the asset 1'; 8) Reselect again on the 'asset 1' (first above) and is possible have a mixed tags of the two assets. An way to verify this is between the steps 2~8 use the Show in Filemanager option to control the effect... because flipping a bit the eyes :)
All the effects are related with Edit and Add new tags instance on the asset.
Confirming. Tags are currently unusable in master.
It would be nice if the approximate size of the brush were an automatically created tag. This could be done using the longest dimension of the brush, and setting the approximate dimension to the nearest of these sizes: 032px, 064px, 128px, 256px, with two additional categories for smaller than 32px and larger than 256px. I found out the hard way that trying to add tags to GIMP brushes doesn't work. So I'm in the process of adding an approximate size tag to my brushes, by directly editing the tags.xml file, using screenshots of the brush list as filtered by folder, so I can see the brush sizes without having GIMP open. I suspect that my effort to tag the brushes by size will eventually be erased/overwritten in the course of future changes to GIMP code, or if I accidentally erase the folder myself, or etc/etc. I'm saying this based on very bad experiences with trying to tag krita brushes - *all* efforts that I have put into customizing and tagging my krita brushes have been repeatedly deleted by krita updates, so I don't even bother with krita any more. It would be nice if GIMP could have a direct brush metadata editor, such that tags and changes in the brush name as displayed in the GIMP brush drop-down list could be user-editable, *safely in the metadata of the actual brush* instead of in a fragile (easily deleted or overwritten or "misplaced" by changes in how config files are handled) xml file on disk.
Seems like the same happens in 2.8.x as well. See https://www.reddit.com/r/GIMP/comments/6skl2s/some_trouble_with_following_ctrlpaint_with_gimp/dldp4cb/ ff. - i.e.: * any tags you assign seems to be assigned to the preset which was last active, not the currently active one (this is not necessarily the preceding one in the list) * the tag input area showing the tags assigned to a preset is only updated after select a different preset
(In reply to Michael Schumacher from comment #4) > Seems like the same happens in 2.8.x as well. > > See > https://www.reddit.com/r/GIMP/comments/6skl2s/ > some_trouble_with_following_ctrlpaint_with_gimp/dldp4cb/ ff. - i.e.: > > > * any tags you assign seems to be assigned to the preset which was last > active, not the currently active one (this is not necessarily the preceding > one in the list) > > * the tag input area showing the tags assigned to a preset is only updated > after select a different preset I tested the tool presets list view dialog and the assign tag entry shows the tags of the previously selected preset after clicking on one preset in the list. The problem is that the select_item signal handler of the container editor is run before the treeview updated the selection, but during its execution it asks the treeview the list of selected items and it receives the list of items selected previously and the tag entry has the wrong preset. passing G_CONNECT_AFTER instead of 0 here: https://git.gnome.org/browse/gimp/tree/app/widgets/gimpcontainereditor.c#n280 the tags shown are those of the currently selected preset. I don't know if such a change would have unwanted effects elsewhere. BTW clicking on the topmost preset, before anyone is selected does not select it, I have to click on another one before being able to select it
Thanks, fixed in master: commit 1a23115024397584e2065c38fc706155346e3262 Author: Michael Natterer <mitch@gimp.org> Date: Thu Jan 11 21:30:37 2018 +0100 Bug 784176 - Tags are exchanged between different assets... ...on the list dialogs on the Input text area gimp_container_editor_constructed(): connect the container view's "select-item" with G_CONNECT_AFTER because the signal is G_SIGNAL_RUN_LAST. Some quick greps didn't find anything that would be affected, except fixing this bug. Found by Massimo. app/widgets/gimpcontainereditor.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)