After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784130 - Times in the world's clocks are shown in reverse in RTL languages
Times in the world's clocks are shown in reverse in RTL languages
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: calendar
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-06-23 14:27 UTC by Arash Mousavi
Modified: 2017-07-05 14:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot representing the issue (51.38 KB, image/png)
2017-06-23 14:27 UTC, Arash Mousavi 		  Details
util: Force text direction of time strings (1.55 KB, patch)
2017-06-23 16:37 UTC, Florian Müllner 		committed Details | Review

Description Arash Mousavi 2017-06-23 14:27:38 UTC 
Created attachment 354315 [details]
Screenshot representing the issue

This is similar to #745111.
The place for hour and minutes in the bottom left side of the dropdown is reversed as in the screenshot attached.
Comment 1 Florian Müllner 2017-06-23 16:37:22 UTC 
Created attachment 354325 [details] [review]
util: Force text direction of time strings

While the string returned by formatTime() should follow the locale's
text direction as a whole, the actual time part is always expected
to put hours on the left and minutes to the right. It is possible to
enforce that by inserting a left-to-right mark, but so far this is
only done by the Hebrew translation. So in order to not require all
other RTL translations to be fixed individually, just insert the
mark into the returned string ourselves like gnome-desktop's WallClock
code does[0].

[0] https://git.gnome.org/browse/gnome-desktop/tree/libgnome-desktop/gnome-wall-clock.c?h=gnome-3-24#n267
Comment 2 Rui Matos 2017-07-05 12:30:29 UTC 
Review of attachment 354325 [details] [review]:

lgtm
Comment 3 Florian Müllner 2017-07-05 14:50:15 UTC 
Attachment 354325 [details] pushed as fdf988c - util: Force text direction of time strings