After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784105 - shell-search-provider: Only use location in description
shell-search-provider: Only use location in description
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-06-22 21:49 UTC by Florian Müllner
Modified: 2017-08-07 13:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
shell-search-provider: Only use location in description (2.12 KB, patch)
2017-06-22 21:49 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2017-06-22 21:49:04 UTC
See patch.
Comment 1 Florian Müllner 2017-06-22 21:49:08 UTC
Created attachment 354285 [details] [review]
shell-search-provider: Only use location in description

The filename is likely to match the display name, which is already
prominently used as the result name, so including it in the description
doesn't add any information. In fact, as gnome-shell is about to
display name and description on a single line[0], duplicating the
filename increases the chances of less information being displayed
due to ellipsization.

[0] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/shell/search/search-list-layout.png
Comment 2 Carlos Soriano 2017-08-07 10:49:29 UTC
Review of attachment 354285 [details] [review]:

Looks good, thanks!
Comment 3 Florian Müllner 2017-08-07 13:17:29 UTC
Attachment 354285 [details] pushed as 2563120 - shell-search-provider: Only use location in description