GNOME Bugzilla – Bug 784098
rhythmbox fails to build against totem-pl-parser 3.25.3
Last modified: 2017-06-22 16:36:10 UTC
totem-pl-parser 3.25.3 has been released and rhythmbox fails to build against this new version: rb-playlist-source.c:571:34: error: missing binary operator before token "(" #if TOTEM_PL_PARSER_CHECK_VERSION(2,29,1) ^ rb-playlist-source.c: In function 'rb_playlist_source_save_playlist': rb-playlist-source.c:664:34: error: missing binary operator before token "(" #if TOTEM_PL_PARSER_CHECK_VERSION(2,29,1) ^ rb-playlist-source.c:689:34: error: missing binary operator before token "(" #if TOTEM_PL_PARSER_CHECK_VERSION(2,29,1)
I actually move that from rhythmbox to totem-pl-parser, as I think we lost the macro TOTEM_PL_PARSER_CHECK_VERSION there
the generated features.h seems not to be based on features.h.in at all anymore: > cat /usr/include/totem-pl-parser/1/plparser/totem-pl-parser-features.h /* * Autogenerated by the Meson build system. * Do not edit, your changes will be lost. */ #pragma once #define TOTEM_PL_PARSER_VERSION_MAJOR 3 #define TOTEM_PL_PARSER_VERSION_MICRO 3 #define TOTEM_PL_PARSER_VERSION_MINOR 25
Created attachment 354254 [details] [review] build: Re-add TOTEM_PL_PARSER_CHECK_VERSION macro Since the switch to Meson, we are generating totem-pl-parser-features.h "by hand", listing the constants it should contain, instead of replacing a number of digits in a ".in" file. This made us lose the TOTEM_PL_PARSER_CHECK_VERSION helper macro, so re-add it to the main header file.
woulnd't it be 'neater' to just specify the input: to configure_file?
Created attachment 354255 [details] [review] Use totem-pl-parser-features.h.in as base to generate the real header
Created attachment 354257 [details] [review] build: Fix missing TOTEM_PL_PARSER_CHECK_VERSION macro Use totem-pl-parser-features.h.in as base to generate totem-pl-parser-features.h so that TOTEM_PL_PARSER_CHECK_VERSION is present.
Attachment 354257 [details] pushed as cd8cec1 - build: Fix missing TOTEM_PL_PARSER_CHECK_VERSION macro