After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784092 - Corrupted Ripped Files
Corrupted Ripped Files
Status: RESOLVED OBSOLETE
Product: sound-juicer
Classification: Applications
Component: ripping
3.24.x
Other Linux
: Normal major
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-06-22 13:28 UTC by b.lacoste
Modified: 2021-05-17 16:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
log with export G_MESSAGES_DEBUG=sj-metadata (12.16 KB, text/plain)
2017-06-22 17:39 UTC, b.lacoste
Details

Description b.lacoste 2017-06-22 13:28:27 UTC
When ripping CD-DA metadata may be corrupted.

This is NOT occasional, corruption happens to roughly 80% of the track of an album. Reproduced on 3 albums in a row. No metadata were successfully be written for a whole album.

Either the following possibilities are encountered for a track: 
- there is no Metadata at all (only the title is the name of the file)
- several fields missing like "album" / "title" / "track number" / ... 
- one field may be trucated like "A P" instead of "A Perfect Circle" for "Artist"
- cover image is not present.

All the metadata are retrieved from MusicBrainz. 
Ripping use FLAC encoder.

Example : 
https://musicbrainz.org/release/ccee00da-ac94-389b-b65d-a74d092cc94e
Track 5 is ripped only with 
- Title : Orestes
- Artiste : "A P" (instead of "A Perfect Circle")
No other metadata
Comment 1 b.lacoste 2017-06-22 17:39:04 UTC
This is more than Metadata. On other Rip, Music is truncated. MoreOver "EasyTag" cannot retrieve Frequency (44100Hz) in some FLAC file, or the length of track is 0...

Here is attached a log with export G_MESSAGES_DEBUG=sj-metadata. Track 5 metadata are crashed exactly the same way when I reproduce.

OS: ArchLinux
Comment 2 b.lacoste 2017-06-22 17:39:49 UTC
Created attachment 354260 [details]
log with export G_MESSAGES_DEBUG=sj-metadata
Comment 3 Phillip Wood 2017-06-23 10:07:54 UTC
(In reply to b.lacoste from comment #2)
> Created attachment 354260 [details]
> log with export G_MESSAGES_DEBUG=sj-metadata

Thanks for the debug log. I have just tried it and get no metadata in my flac files but do get it in mp3 files so it looks like it could be a problem with gstreamer's flac module. If I run under jhbuild then I get these error messages when extracting
0:00:40.117600576 16983 0x7f3eb0049a30 ERROR              flacparse gstflacparse.c:882:gst_flac_parse_handle_streaminfo:<flacparse1> Invalid metablock size for STREAMINFO: 10
0:00:40.425195658 16983      0x1a461e0 ERROR              flacparse gstflacparse.c:882:gst_flac_parse_handle_streaminfo:<flacparse2> Invalid metablock size for STREAMINFO: 10
0:00:40.444648630 16983 0x7f3e94017540 ERROR              flacparse gstflacparse.c:882:gst_flac_parse_handle_streaminfo:<flacparse3> Invalid metablock size for STREAMINFO: 10
0:00:40.466937134 16983 0x7f3eb0049a30 ERROR              flacparse gstflacparse.c:882:gst_flac_parse_handle_streaminfo:<flacparse4> Invalid metablock size for STREAMINFO: 10

I haven't rebuilt by jhbuild stack for ages, so I'll do that to check if the problem still exists with the current master.
Comment 4 Phillip Wood 2017-06-24 17:38:37 UTC
(In reply to Phillip Wood from comment #3)
> (In reply to b.lacoste from comment #2)
> > Created attachment 354260 [details]
> > log with export G_MESSAGES_DEBUG=sj-metadata
> 
> Thanks for the debug log. I have just tried it and get no metadata in my
> flac files but do get it in mp3 files so it looks like it could be a problem
> with gstreamer's flac module. If I run under jhbuild then I get these error
> messages when extracting
> 0:00:40.117600576 16983 0x7f3eb0049a30 ERROR              flacparse
> gstflacparse.c:882:gst_flac_parse_handle_streaminfo:<flacparse1> Invalid
> metablock size for STREAMINFO: 10
> 0:00:40.425195658 16983      0x1a461e0 ERROR              flacparse
> gstflacparse.c:882:gst_flac_parse_handle_streaminfo:<flacparse2> Invalid
> metablock size for STREAMINFO: 10
> 0:00:40.444648630 16983 0x7f3e94017540 ERROR              flacparse
> gstflacparse.c:882:gst_flac_parse_handle_streaminfo:<flacparse3> Invalid
> metablock size for STREAMINFO: 10
> 0:00:40.466937134 16983 0x7f3eb0049a30 ERROR              flacparse
> gstflacparse.c:882:gst_flac_parse_handle_streaminfo:<flacparse4> Invalid
> metablock size for STREAMINFO: 10
> 
> I haven't rebuilt by jhbuild stack for ages, so I'll do that to check if the
> problem still exists with the current master.

I still can't get sound-juicer to run under jhbuild - it refuses to see the cd drive for same reason. However converting the mp3 I ripped to a flac with gst-launch-1.0 does give the  metadata in the flac file so it's not a straight forward case of flacenc/flactag not working all the time.

$ gst-launch-1.0 filesrc location=d1t05-a_perfect_circle-orestes.mp3 ! decodebin !  audioconvert ! audioresample ! flacenc ! flactag ! filesink location=test.flac
$ metaflac --list --block-type=VORBIS_COMMENT test.flac 
METADATA block #2
  type: 4 (VORBIS_COMMENT)
  is last: true
  length: 548
  vendor string: GStreamer encoded vorbiscomment
  comments: 15
    comment[0]: TITLE=Orestes
    comment[1]: ARTIST=A Perfect Circle
    comment[2]: TRACKTOTAL=12
    comment[3]: TRACKNUMBER=5
    comment[4]: ALBUM=Mer de noms
    comment[5]: MUSICBRAINZ_ALBUMID=ccee00da-ac94-389b-b65d-a74d092cc94e
    comment[6]: MUSICBRAINZ_ALBUMARTISTID=078a9376-3c04-4280-b7d7-b20e158f345d
    comment[7]: ALBUMARTIST=A Perfect Circle
    comment[8]: MUSICBRAINZ_ARTISTID=078a9376-3c04-4280-b7d7-b20e158f345d
    comment[9]: MUSICBRAINZ_TRACKID=84bedce5-9609-411e-8b82-f19ec651d5eb
    comment[10]: ARTISTSORT=Perfect Circle, A
    comment[11]: DATE=2000
    comment[12]: DISCNUMBER=1
    comment[13]: DISCID=6a11b818
    comment[14]: MUSICBRAINZ_DISCID=.SBp5AwBaU.VwzlEu6qQvgRxV5o-
Comment 5 Phillip Wood 2017-07-17 10:10:26 UTC
Since upgrading to gstreamer 1.12.2-1 on Arch Linux flac extraction seems to be working again for me, can you check if you still have a problem please.
Comment 6 b.lacoste 2017-07-17 10:21:11 UTC
Sure, I will test it next week as I cannot do it this week.
Thanks for the update.
Comment 7 b.lacoste 2017-07-30 12:42:36 UTC
Issue NOT fixed for me. I have gstreamer-1.12.2-1, no Track name nor other elements are retrieved by EasyTag or Rythmbox.
Comment 8 Philipp Wolfer 2017-09-06 08:04:46 UTC
I have filed the somewhat similar issue #785558, but for me the behavior is somewhat different then originally described here (it happens all the time, not only sometimes, different error messages.
Comment 9 Philipp Wolfer 2017-09-06 08:05:07 UTC
https://bugzilla.gnome.org/show_bug.cgi?id=785558
Comment 10 GNOME Infrastructure Team 2021-05-17 16:09:27 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/sound-juicer/-/issues/179.