After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784082 - meson option 'with-package-name'
meson option 'with-package-name'
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-build
1.12.1
Other Linux
: Normal minor
: 1.12.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-06-22 08:39 UTC by kyrios
Modified: 2017-07-03 20:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description kyrios 2017-06-22 08:39:40 UTC 
GST_PACKAGE_NAME is only set when you can match it, so meson build fails when used with 'with-package-name'.

Error is:

../gst/gst.c:710:7: error: 'GST_PACKAGE_NAME' undeclared (first use in this function); did you mean 'PACKAGE_NAME'?
Comment 1 Tim-Philipp Müller 2017-06-23 10:13:06 UTC 
This should fix it:

commit 3683a0753aa4fc43f3fa9c14114076d5dbfc1420
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Fri Jun 23 11:11:44 2017 +0100

    meson: fix with-package-name option
    
    https://bugzilla.gnome.org/show_bug.cgi?id=784082


Any chance you could test, just to double-check? I'll then backport it to 1.12 and to the other modules.
Comment 2 kyrios 2017-06-23 18:32:36 UTC 
I get the following message when I click on your commit : "No repositories found" ???
Comment 3 Tim-Philipp Müller 2017-06-23 18:44:13 UTC 
That's because it's not hosted in gnome's git :)

https://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=3683a0753aa4fc43f3fa9c14114076d5dbfc1420
Comment 4 kyrios 2017-06-23 20:06:46 UTC 
I confirm the patch works fine !
Thanks !! :-)