GNOME Bugzilla – Bug 784072
Show mapping notes in edit dialog
Last modified: 2017-07-24 10:47:56 UTC
OpenStreetMap has a 'note' tag [1] which is used "to inform other mappers about non-obvious information about an element, the author's intent when creating it, or hints for further improvement". Attached patch makes the notes show when editing points of interest. [1] https://wiki.openstreetmap.org/wiki/Key:note
Created attachment 354209 [details] [review] osmEditDialog: Add edit/add of notes
Created attachment 354210 [details] Screenshot showing notes in edit dialog
The notes should possibly be shown in a GtkTextView instead of GtkEntry, but I figured we should at least show them first and enhance it later if necessary.
Yeah, a text view would probably be even better, but I guess it would need some thought. I guess just adding it to the present edit view wouldn't fit too well. Maybe an option could be to have some way to expand a text entry to reveal a full text view. But for now, I think we could go for the simple text entry. I wonder though if this field should have a hint explaining that this note is meant for internal edit purposes (i.e. not typically shown on maps, and not a general presentation of the object)?
Created attachment 355198 [details] [review] osmEditDialog: Add edit/add of notes Add hint about usage of note field.
Review of attachment 355198 [details] [review]: LGTM