GNOME Bugzilla – Bug 784050
Warning fixes
Last modified: 2017-06-22 07:04:57 UTC
.
Created attachment 354177 [details] [review] lib: Fix mixed declarations and code "ISO C90 forbids mixed declarations and code"
Created attachment 354178 [details] [review] lib: Make private functions static Fixes "no previous prototype for ..." warnings
Created attachment 354179 [details] [review] lib: Make "transfer none" strings "const" instead Fixes "return discards ‘const’ qualifier from pointer target type" warnings and removes the need for an introspection tag.
Created attachment 354180 [details] [review] lib: Fix "enumeration value not handled in switch" "enumeration value ‘GEPUBTextNormal’ not handled in switch"
Created attachment 354181 [details] [review] lib: Fix discarding const qualifier passing argument 2 of ‘gepub_utils_has_parent_tag’ discards ‘const’ qualifier from pointer target type
Created attachment 354182 [details] [review] lib: Fix memory leaks and warnings in gepub_utils_has_parent_tag() Both the node name and what we were comparing it against were leaked at every iteration of the loop.
Created attachment 354183 [details] [review] lib: Fix unused functions and variables warnings
Created attachment 354184 [details] [review] fixup! lib: Make private functions static
Created attachment 354185 [details] [review] lib: Fix obviously incorrect comparison We assign "contents" but check "res" for != NULL...
Created attachment 354186 [details] [review] lib: Make private functions static Fixes "no previous prototype for ..." warnings
Please review those carefully, especially with https://bugzilla.gnome.org/show_bug.cgi?id=784049 in mind.
Attachment 354177 [details] pushed as c48f858 - lib: Fix mixed declarations and code Attachment 354179 [details] pushed as 85e1181 - lib: Make "transfer none" strings "const" instead Attachment 354180 [details] pushed as 7127341 - lib: Fix "enumeration value not handled in switch"
Comment on attachment 354182 [details] [review] lib: Fix memory leaks and warnings in gepub_utils_has_parent_tag() Attachment 354182 [details] pushed as 5ca8b09 - lib: Fix memory leaks and warnings in gepub_utils_has_parent_tag()
Attachment 354181 [details] pushed as 67e3b79 - lib: Fix discarding const qualifier Attachment 354183 [details] pushed as 2691800 - lib: Fix unused functions and variables warnings Attachment 354185 [details] pushed as 81b37ad - lib: Fix obviously incorrect comparison Attachment 354186 [details] pushed as 7f48731 - lib: Make private functions static