After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784037 - gio: Mention the ALL_METADATA flag in g_file_copy()
gio: Mention the ALL_METADATA flag in g_file_copy()
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: docs
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-06-21 13:54 UTC by Emanuele Aina
Modified: 2017-06-21 15:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gio: Mention the ALL_METADATA flag in g_file_copy() (1.30 KB, patch)
2017-06-21 13:54 UTC, Emanuele Aina 		committed Details | Review

Description Emanuele Aina 2017-06-21 13:54:08 UTC 
Since the g_file_copy() documentation doesn't mention if
G_FILE_COPY_ALL_METADATA is applicable or not I initially used
g_file_copy_attributes() to specify it after the g_file_copy() call.

I then checked the source and the separate step does not seem to be needed,
let's make that explicit in the documentation. :)
Comment 1 Emanuele Aina 2017-06-21 13:54:13 UTC 
Created attachment 354155 [details] [review]
gio: Mention the ALL_METADATA flag in g_file_copy()

The g_file_copy() documentation didn't mention if
G_FILE_COPY_ALL_METADATA was applicable or not, and users were led to
call g_file_copy_attributes() to specify it after the g_file_copy()
call, unless they checked the source (been there, done that).
Comment 2 Philip Withnall 2017-06-21 14:07:05 UTC 
Review of attachment 354155 [details] [review]:

Yes!
Comment 3 Emanuele Aina 2017-06-21 15:28:59 UTC 
The following fix has been pushed:
79e4d4c gio: Mention the ALL_METADATA flag in g_file_copy()