After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784013 - Routing from place bubble broken for transit
Routing from place bubble broken for transit
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2017-06-20 19:51 UTC by Marcus Lundblad
Modified: 2017-06-20 20:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
routingDelegator: Add function to reset (1.02 KB, patch)
2017-06-20 20:04 UTC, Marcus Lundblad
committed Details | Review
mapBubble: Don't hard-code to non-transit mode (1.32 KB, patch)
2017-06-20 20:04 UTC, Marcus Lundblad
committed Details | Review

Description Marcus Lundblad 2017-06-20 19:51:26 UTC
As a fallout from bug https://bugzilla.gnome.org/show_bug.cgi?id=783089 routing is now broken when the last uses state was "transit" and the user initiates a "route to here" action from a place bubble. The problem is that some of that code was still assuming the "reset to car as the default" behaviour and now gets into a mixed state telling the routing delegator to use non-transit mode while the transport mode is set to "transit".
Comment 1 Marcus Lundblad 2017-06-20 20:04:11 UTC
Created attachment 354122 [details] [review]
routingDelegator: Add function to reset

This function will reset the turn-by-turn route object or
the transit plan for transit mode. This will be used by
the map bubble to reset when requesting a route to the current
object.
Comment 2 Marcus Lundblad 2017-06-20 20:04:25 UTC
Created attachment 354123 [details] [review]
mapBubble: Don't hard-code to non-transit mode

Setting non-transit here unconditionally results in a inconsitent
state when the mode is set to transit.
Also reset the appropriate object depending on routing mode.
Comment 3 Marcus Lundblad 2017-06-20 20:17:24 UTC
Attachment 354122 [details] pushed as 9f9c94b - routingDelegator: Add function to reset
Attachment 354123 [details] pushed as 10f69ec - mapBubble: Don't hard-code to non-transit mode