After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783986 - Appdata.xml file is no longer being installed
Appdata.xml file is no longer being installed
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2017-06-20 09:43 UTC by Dominique Leuenberger
Modified: 2017-06-20 10:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix appdata.xml installation (1.48 KB, patch)
2017-06-20 10:04 UTC, Dominique Leuenberger 		none Details | Review

Description Dominique Leuenberger 2017-06-20 09:43:44 UTC 
I just packaged up gnome-calculator 3.25.3 and have seen that /usr/share/appdata/org.gnome.Calculator.appdata.xml is no longer being installed

This seems to be a fallout of

https://git.gnome.org/browse/gnome-calculator/commit/?id=800ccb84cc9d2500204e22d42fd84d2462309f3d

Looking into Makefile.in (the one generated by autoconf), one sees:

> appdata_in_files = org.gnome.Calculator.appdata.xml.in

and then further down, translated from @APPSTREAM_XML_RULES@

>$(appstream_XML): $(appstream_in_files)
>        $(AM_V_GEN) $(MSGFMT) --xml --template $< -d $(top_srcdir)/po -o $@

And there the variable name does not match to the earlier definition
Comment 1 Dominique Leuenberger 2017-06-20 10:04:01 UTC 
Created attachment 354089 [details] [review]
Fix appdata.xml installation

With the migration away from libtool to using APPSTREAM_XML_RULES (commit 800ccb84c) some variables were not adjusted.
Comment 2 Robert Roth 2017-06-20 10:34:32 UTC 
Silly me, I saw that appdata.xml in git unstaged, and didn't think about the reason. THanks for spotting this.
Comment 3 Robert Roth 2017-06-20 10:36:17 UTC 
Thanks for the patch.

Attachment 354089 [details] pushed as 60f3a35 - Fix appdata.xml installation