The patch doesn't seem to be generated with `git format-patch`, so there is no [review] link, and `git bz apply 783964` fails.

The patch looks good, although I won't be able to test it. I wonder if GDK provides enum values or #defines for the buttons, to replace 8 and 9 (and 3). 1, 2, 3 are still more or less obvious, but 8 and 9 are far less obvious.

(In reply to Sébastien Wilmet from comment #1)
> The patch doesn't seem to be generated with `git format-patch`, so there is
> no [review] link, and `git bz apply 783964` fails.

I think the issue was that the "Patch" link was not checked in the attachment details. Fixed now, the Review link is there.

> The patch looks good, although I won't be able to test it. I wonder if GDK
> provides enum values or #defines for the buttons, to replace 8 and 9 (and
> 3). 1, 2, 3 are still more or less obvious, but 8 and 9 are far less obvious.

There doesn't seem to be any. A quick look at epiphany source suggests that they do exactly the same thing (using number literals in the same fashion).

Review of attachment 354045 [details] [review]:

Looks good, thanks.

Comment on attachment 354045 [details] [review]
A fix

Pushed with some small modifications:
https://git.gnome.org/browse/devhelp/commit/?id=5dc50336d6879cd38cf19c0254fd9719fb1ba66a