After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783861 - h264parse : H264 that have SPS without PPS following
h264parse : H264 that have SPS without PPS following
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-06-16 12:17 UTC by Aurelien BOUIN
Modified: 2018-11-03 14:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Attached is a H264 video with PPS missing (2.24 MB, text/vnd.trolltech.linguist)
2017-06-16 13:19 UTC, Aurelien BOUIN 		  Details
PATCH : It solves the problem and do not change the old behaviour (873 bytes, patch)
2017-06-16 13:21 UTC, Aurelien BOUIN 		none Details | Review

Description Aurelien BOUIN 2017-06-16 12:17:52 UTC 
h264parse drop frames when there was no previous picture headers ( GST_H264_PARSE_STATE_VALID_PICTURE_HEADERS).
But some H264 encoder generate SPS header without PPS header following ...
The code in plugins-bad/gst/videoparsers/gsth264parse.c when receiving SPS GST_H264_NAL_SUBSET_SPS reset h264parse->state to 0 (meaning that previous SPS and PPS headers are ignored), instead of just considering SPS state only
So the change would be something like :
h264parse->state &= GST_H264_PARSE_STATE_GOT_PPS;
instead of 
h264parse->state = 0;

Attached is a H264 video with PPS missing
Comment 1 Aurelien BOUIN 2017-06-16 13:19:57 UTC 
Created attachment 353895 [details]
Attached is a H264 video with PPS missing
Comment 2 Aurelien BOUIN 2017-06-16 13:21:49 UTC 
Created attachment 353896 [details] [review]
PATCH : It solves the problem and do not change the old behaviour
Comment 3 GStreamer system administrator 2018-11-03 14:09:51 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/571.