After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783848 - local-provider: Purge memory leak
local-provider: Purge memory leak
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-06-16 02:18 UTC by Mohammed Sadiq
Modified: 2017-06-18 20:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
local-provider: Purge memory leak (833 bytes, patch)
2017-06-16 02:18 UTC, Mohammed Sadiq 		none Details | Review
local-note: Purge memory leak when deleting note (1.15 KB, patch)
2017-06-16 02:26 UTC, Mohammed Sadiq 		accepted-commit_now Details | Review
local-provider: Purge memory leak (754 bytes, patch)
2017-06-16 06:32 UTC, Mohammed Sadiq 		accepted-commit_now Details | Review

Description Mohammed Sadiq 2017-06-16 02:18:42 UTC 
.
Comment 1 Mohammed Sadiq 2017-06-16 02:18:49 UTC 
Created attachment 353866 [details] [review]
local-provider: Purge memory leak
Comment 2 Mohammed Sadiq 2017-06-16 02:26:50 UTC 
Created attachment 353867 [details] [review]
local-note: Purge memory leak when deleting note

The path obtained for debug text was leaking, fix that.
Comment 3 Jonathan Kang 2017-06-16 06:18:55 UTC 
Review of attachment 353866 [details] [review]:

::: src/libbiji/provider/biji-local-provider.c
@@ +415,3 @@
       ret = biji_local_note_new_from_info (BIJI_PROVIDER (self), manager, &set);
 
+    g_free (folder);

folder should be freed outside of the while loop.
Comment 4 Jonathan Kang 2017-06-16 06:19:27 UTC 
Review of attachment 353867 [details] [review]:

Looks good to me.
Comment 5 Mohammed Sadiq 2017-06-16 06:32:50 UTC 
Created attachment 353871 [details] [review]
local-provider: Purge memory leak
Comment 6 Jonathan Kang 2017-06-16 06:52:27 UTC 
Review of attachment 353871 [details] [review]:

Looks good.
Comment 7 Isaque Galdino 2017-06-18 20:20:48 UTC 
Pushed to master.