After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783796 - [PATCH] gio: don't fail the GDBusObjectManagerClient initialization if the service disappears
[PATCH] gio: don't fail the GDBusObjectManagerClient initialization if the se...
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-06-14 20:01 UTC by Lubomir Rintel
Modified: 2018-05-24 19:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (3.11 KB, patch)
2017-06-14 20:01 UTC, Lubomir Rintel 		reviewed Details | Review

Description Lubomir Rintel 2017-06-14 20:01:42 UTC 
Created attachment 353767 [details] [review]
Proposed patch

The current initialization sequence is racy -- the service could go away
between we check for the bus name presence and the call to
GetManagerObjects. Let's not fail the initialization in such case --
wait for the service to reappear instead.
Comment 1 Philip Withnall 2017-06-16 10:02:05 UTC 
Review of attachment 353767 [details] [review]:

This looks reasonable, but it would be good to have a unit test for it. Can you please add one?
Comment 2 GNOME Infrastructure Team 2018-05-24 19:37:30 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/1274.