After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783785 - [review] add support for domain search list (option 119) to internal DHCP (systemd) [th/sd-dhcp-domain-search-list-bgo783785]
[review] add support for domain search list (option 119) to internal DHCP (sy...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-06-14 12:23 UTC by Thomas Haller
Modified: 2017-06-14 13:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2017-06-14 12:23:28 UTC 
Now that sd_dhcp_lease support it natively...
Comment 1 Beniamino Galvani 2017-06-14 13:41:48 UTC 
> dhcp/systemd: add support for DHCPv4 domain search list (option 119)

    LOG_LEASE (LOGD_DHCP6, "domain search list '%s'", search_domains[i]);

LOGD_DHCP4

Can you replace the string with "domain search '%s'", for consistency with nm-dhcp-utils.c?

The rest LGTM.

Also, please close or duplicate bug 750076.