After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783641 - tz.c: compiler warning: implicit declaration of function ‘islower’
tz.c: compiler warning: implicit declaration of function ‘islower’
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: datetime
unspecified
Other Solaris
: Normal normal
: ---
Assigned To: Kalev Lember
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2017-06-10 19:26 UTC by Alan Coopersmith
Modified: 2017-06-12 15:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to add #include <ctype.h> to plugins/datetime/tz.c (849 bytes, patch)
2017-06-10 19:29 UTC, Alan Coopersmith 		committed Details | Review

Description Alan Coopersmith 2017-06-10 19:26:29 UTC 
Building gnome-settings-daemon on Solaris, from released tarball or git master
warns:

tz.c: In function ‘tz_load_db’:
tz.c:96:48: warning: implicit declaration of function ‘islower’ [-Wimplicit-function-declaration]
   if (tmpstrarr[3] && *tmpstrarr[3] != '-' && !islower(loc->zone)) {
                                                ^
Adding an include of the standard <ctype.h> header fixes it.
Comment 1 Alan Coopersmith 2017-06-10 19:29:42 UTC 
Created attachment 353545 [details] [review]
Patch to add #include <ctype.h> to plugins/datetime/tz.c
Comment 2 Rui Matos 2017-06-12 15:00:35 UTC 
Review of attachment 353545 [details] [review]:

looks fine, thanks
Comment 3 Rui Matos 2017-06-12 15:01:15 UTC 
To ssh://git.gnome.org/git/gnome-initial-setup
   7b83212..8105660  master -> master
Comment 4 Rui Matos 2017-06-12 15:02:24 UTC 
To ssh://git.gnome.org/git/gnome-settings-daemon
   884ebb4..f352e64  gnome-3-24 -> gnome-3-24
   f3367d6..de63819  master -> master
Comment 5 Rui Matos 2017-06-12 15:03:52 UTC 
To ssh://git.gnome.org/git/gnome-control-center
   bab859a..f090d7e  master -> master