After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783617 - build: Add meson support
build: Add meson support
Status: RESOLVED OBSOLETE
Product: gnome-user-docs
Classification: Core
Component: general
3.24.x
Other All
: Normal normal
: ---
Assigned To: Maintainers of Gnome user documentation
Maintainers of Gnome user documentation
Depends on: 783099 785522
Blocks: 782980
 
 
Reported: 2017-06-10 01:32 UTC by Jeremy Bicha
Modified: 2018-03-26 14:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Add meson support (15.34 KB, patch)
2017-06-10 01:32 UTC, Jeremy Bicha
none Details | Review
3.26: Switch gnome-user-docs to meson (951 bytes, patch)
2017-06-10 01:33 UTC, Jeremy Bicha
none Details | Review

Description Jeremy Bicha 2017-06-10 01:32:03 UTC
To try this out once the jhbuild patch is applied, you can run jhbuild buildone gnome-user-docs assuming you have an up-to-date jhbuild.

Or you could run something like
meson builddir
ninja -C builddir
ninja -C builddir install
Comment 1 Jeremy Bicha 2017-06-10 01:32:06 UTC
Created attachment 353501 [details] [review]
build: Add meson support

https://wiki.gnome.org/Initiatives/GnomeGoals/MesonPorting
Comment 2 Jeremy Bicha 2017-06-10 01:33:09 UTC
Created attachment 353502 [details] [review]
3.26: Switch gnome-user-docs to meson

The jhbuild patch
Comment 3 Jeremy Bicha 2017-06-10 16:05:08 UTC
To make a release tarball after switching to meson and dropping autotools support, you can use this script (change the name from epiphany):

https://git.gnome.org/browse/epiphany/tree/make_release.sh

meson 0.41 will be released soon with a built-in way to make tarballs.
Comment 4 Petr Kovar 2017-06-11 18:13:50 UTC
Thanks for the patches, Jeremy. Now that is a GNOME Goal, I guess it makes sense to switch everything. Would you be able to provide patches for other -docs modules as well?
Comment 5 Jeremy Bicha 2017-06-11 18:24:13 UTC
(In reply to Petr Kovar from comment #4)
> Thanks for the patches, Jeremy. Now that is a GNOME Goal, I guess it makes
> sense to switch everything. Would you be able to provide patches for other
> -docs modules as well?

I think it's an optional GNOME goal, but it looks like most GNOME maintainers like meson or don't mind the change too much.

Are you thinking of any other modules besides gnome-devel-docs? That one is a bit more complicated because it has some build tests in platform-demos, but I or someone could probably figure it out.
Comment 6 Petr Kovar 2017-06-11 18:54:25 UTC
(In reply to Jeremy Bicha from comment #5)

> Are you thinking of any other modules besides gnome-devel-docs? That one is
> a bit more complicated because it has some build tests in platform-demos,
> but I or someone could probably figure it out.

https://git.gnome.org/browse/gnome-getting-started-docs/
Comment 7 Jeremy Bicha 2017-06-11 19:16:23 UTC
(In reply to Petr Kovar from comment #6)
> https://git.gnome.org/browse/gnome-getting-started-docs/

I think that's going to increase the size of the tarballs a bit because I think the tarball will include the animation/ directory. But technically, I believe distros prefer that source tarballs include all the source files.
Comment 8 Petr Kovar 2017-06-11 19:41:45 UTC
(In reply to Jeremy Bicha from comment #7)
> (In reply to Petr Kovar from comment #6)
> > https://git.gnome.org/browse/gnome-getting-started-docs/
> 
> I think that's going to increase the size of the tarballs a bit because I
> think the tarball will include the animation/ directory. But technically, I
> believe distros prefer that source tarballs include all the source files.

Not really a Meson user, but is there no way to exclude source directories? Distributing contents in animation/ is not very useful. Anyway, this should probably go into a separate bug.
Comment 9 Jeremy Bicha 2017-06-11 19:46:20 UTC
Yes, I can open additional bugs, but I'd like to wait for the conversion of this module to happen first in case there any concerns or issues.
Comment 10 Jeremy Bicha 2017-06-13 14:33:52 UTC
meson 0.41 was just released with support for creating tarballs. You can use it like this:

meson builddir
ninja -C builddir dist

The tarball will then be in the builddir/meson-dist/ directory.

http://mesonbuild.com/Creating-releases.html

It does not support excluding files but I think theanimation/ directory really ought to be included in the release tarballs anyway since it is indeed part of the source code.
Comment 11 Petr Kovar 2017-06-27 16:25:25 UTC
It seems like we need to wait until Damned Lies actually supports Meson.
Comment 12 Jeremy Bicha 2017-06-27 16:33:01 UTC
For now, I pushed the buildsystem change to the wip/switch-to-meson branch so that it can be more easily tested.
Comment 13 GNOME Infrastructure Team 2018-03-26 14:35:24 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-user-docs/issues/18.