After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783613 - build: Add meson support
build: Add meson support
Status: RESOLVED FIXED
Product: gnome-font-viewer
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gnome-font-viewer-maint
gnome-font-viewer-maint
Depends on: 783611
Blocks: 783640
 
 
Reported: 2017-06-09 21:35 UTC by Jeremy Bicha
Modified: 2017-07-11 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Add meson support (5.36 KB, patch)
2017-06-09 21:35 UTC, Jeremy Bicha
none Details | Review
build: Place D-Bus service in its own file (2.03 KB, patch)
2017-06-09 22:29 UTC, Jeremy Bicha
none Details | Review
build: Add meson support (4.92 KB, patch)
2017-06-09 22:29 UTC, Jeremy Bicha
committed Details | Review
3.26: Switch gnome-font-viewer to meson (1.01 KB, patch)
2017-06-09 22:35 UTC, Jeremy Bicha
committed Details | Review
build: Place D-Bus service in its own file (1.94 KB, patch)
2017-06-10 17:45 UTC, Jeremy Bicha
committed Details | Review
build: Remove autotools support (6.29 KB, patch)
2017-06-10 18:32 UTC, Jeremy Bicha
committed Details | Review

Comment 1 Jeremy Bicha 2017-06-09 21:35:17 UTC
Created attachment 353493 [details] [review]
build: Add meson support
Comment 2 Cosimo Cecchi 2017-06-09 21:58:43 UTC
Review of attachment 353493 [details] [review]:

Not a meson guru, but this looks generally good to me with a couple minor comments.

::: src/meson.build
@@ +47,3 @@
+)
+
+service_conf = configuration_data ()

Can't help but notice that all the other "function calls" don't have a space before the paren

::: src/org.gnome.font-viewer.service.in
@@ +1,3 @@
+[D-BUS Service]
+Name=org.gnome.font-viewer
+Exec=@BINDIR@gnome-font-viewer --gapplication-service

This is also created by the autotools build, so I'd prefer if you split it into a separate file first.
Comment 3 Jeremy Bicha 2017-06-09 22:29:16 UTC
Created attachment 353495 [details] [review]
build: Place D-Bus service in its own file
Comment 4 Jeremy Bicha 2017-06-09 22:29:51 UTC
Created attachment 353496 [details] [review]
build: Add meson support

https://wiki.gnome.org/Initiatives/GnomeGoals/MesonPorting
Comment 5 Jeremy Bicha 2017-06-09 22:35:44 UTC
Created attachment 353497 [details] [review]
3.26: Switch gnome-font-viewer to meson

and drop intltool dependency

This patch is for jhbuild.

I meant to have 783611 and 783612 to be part of this bug too but I mixed up the git bz syntax.
Comment 6 Cosimo Cecchi 2017-06-10 16:59:56 UTC
Review of attachment 353495 [details] [review]:

Looks good with the change below

::: src/Makefile.am
@@ +59,3 @@
+servicedir = $(datadir)/dbus-1/services
+service_in_files = org.gnome.font-viewer.service.in
+service_DATA = $(service_in_files:.service.in=.service)

Please reuse the variables above
Comment 7 Cosimo Cecchi 2017-06-10 17:00:51 UTC
Review of attachment 353496 [details] [review]:

Looks good
Comment 8 Cosimo Cecchi 2017-06-10 17:01:08 UTC
Review of attachment 353497 [details] [review]:

OK
Comment 9 Jeremy Bicha 2017-06-10 17:45:18 UTC
Created attachment 353541 [details] [review]
build: Place D-Bus service in its own file
Comment 10 Cosimo Cecchi 2017-06-10 17:57:15 UTC
Review of attachment 353541 [details] [review]:

Looks good
Comment 11 Jeremy Bicha 2017-06-10 18:12:27 UTC
Attachment 353496 [details] pushed as 798a942 - build: Add meson support
Attachment 353541 [details] pushed as 08d1f19 - build: Place D-Bus service in its own file
Comment 12 Jeremy Bicha 2017-06-10 18:14:05 UTC
Comment on attachment 353497 [details] [review]
3.26: Switch gnome-font-viewer to meson

Attachment 353497 [details] pushed as aeae1ae - 3.26: Switch gnome-font-viewer to meson
Comment 13 Cosimo Cecchi 2017-06-10 18:28:58 UTC
Can we close the ticket, or is there anything else to do?
Comment 14 Jeremy Bicha 2017-06-10 18:32:03 UTC
Created attachment 353543 [details] [review]
build: Remove autotools support

It looks like gnome-continuous has built gnome-font-viewer successfully with meson:

https://build.gnome.org/continuous/buildmaster/builds/2017/06/10/32/build/

The next version of meson 0.41 is expected soon with built-in ability to make tarballs.

If you need to do a tarball release before then, I recommend using
https://git.gnome.org/browse/epiphany/tree/make_release.sh
but change the name from 'epiphany'
Comment 15 Cosimo Cecchi 2017-07-11 09:23:16 UTC
Review of attachment 353543 [details] [review]:

Let's go for this, assuming that you have tested the build and it produced all the expected output.
Comment 16 Jeremy Bicha 2017-07-11 10:03:04 UTC
Attachment 353543 [details] pushed as ea583a0 - build: Remove autotools support