GNOME Bugzilla – Bug 783607
Rename 'Tweak Tool' to 'Tweaks'
Last modified: 2017-07-19 20:10:11 UTC
To match the naming convention of GNOME core apps, it might be a good idea to rename 'Tweak Tool' to 'Tweaks'. By the way, the last time this app was renamed was bug 678778.
Created attachment 353715 [details] [review] Rename app to GNOME Tweaks Seems little discuss on IRC will be a good idea. script name change on https://git.gnome.org/browse/gnome-tweak-tool/commit/?id=400f842ff3518a986915811fc0a05cf8f56b70d3 (but former name was main.py) title name change on https://git.gnome.org/browse/gnome-tweak-tool/commit/?id=7c468709ced7868f17998d0b048c2501b9e0470c (from System Settings that was the problem described on bug 6787789) Anyway here is a patch for that: It will need to change: - product on bugzilla - git repo on git.gnome.org - wiki page on wiki.gnome.org - modulesets on jhbuild redirecting from old urls to new ones makes sense for historical purposes
Review of attachment 353715 [details] [review]: I'm not interested in changing the git repo or bugzilla product name or tarball name right now. That means leave line 1 of meson.build alone and don't change the copyright headers. Please do not rename the lid-inhibitor as that can cause some problems for people on upgrades who have turned off Power>Suspend when laptop lid is closed. Please don't change the NEWS file as currently that's done as part of the tarball release process. I asked in #gnome-design about this rename before you did. Allan Day was skeptical about changing the name, but Matthias Clasen thought it was a good idea. So far, I think we'll go ahead with the name change.
This change seems counter-productive to me. The name is well-established and the benefit is minimal at best. "Tweaks" also sounds a bit odd to my ears.
Allan, I respect your input and I would prefer to have your approval. On the other hand, I don't think I'm going to hold off on this change if I don't have your approval. This is simply following the naming convention you helped establish for GNOME apps. Since Tweak Tool's UI is being refreshed this cycle, it seems a reasonable time to also refresh the name.
One of the issues is that all the other app names like "Documents", "Settings", "Videos" refer to a collection of objectifiable things. A "tweak" isn't a thing - it's a verb, not a noun.
(In reply to Allan Day from comment #5) > "tweak" isn't a thing - it's a verb, not a noun. "Tweak" is a noun too: https://en.oxforddictionaries.com/definition/tweak
Seen the other way around, tool suffix is redundant. But without rename all related stuff I think is the start of a quirk that only veterans will understand. I would avoid that duality.
(In reply to Jeremy Bicha from comment #6) > (In reply to Allan Day from comment #5) > > "tweak" isn't a thing - it's a verb, not a noun. > > "Tweak" is a noun too: > https://en.oxforddictionaries.com/definition/tweak Fine. It's still not an objectifiable thing.
Hands on it. icons shouldn't be renamed neither? I guess after rework you will need to point out other things I renamed that do not need to be renamed
Alberto, let's keep the existing filenames for the .desktop, icons and Appstream metadata for now. If we do get around to changing the filename later, we may want to switch to the reverse domain name style many other GNOME apps are using. Basically, we're just changing the user-visible naming and the binary name. I'd like to go ahead and land this for the 3.25.4 release next week. That way there's still time to revert if necessary before the 3.26 UI Freeze. Could you please update your patch before Monday night?
I will rework it this weekend
Created attachment 355785 [details] [review] Rename app to GNOME Tweaks Hope these are all the changes involved
Review of attachment 355785 [details] [review]: Please change the binary name too.
Created attachment 355787 [details] [review] Rename app to GNOME Tweaks
Next time, could you look into either using 'git format-patch' to prepare the patch you attach? That way it can be applied directly with 'git am' Or you could use git-bz which is very popular among GNOME contributors: http://git.fishsoup.net/cgit/git-bz/plain/git-bz http://git.fishsoup.net/man/git-bz.html I made one change (made sure the .desktop has the new binary name in its Exec= line) and pushed. Thank you for helping to make GNOME better!
One more benefit of 'git bz' is that it adds a reference to the bug to your proposed patch. So if you don't use 'git bz', please add a link to the bug in your commit message.
Opps, sure. You told me several times. Didn't realize git show and git format-patch are not exactly the same too. It's just cookie credentials read from git bz didn't work for me in the past, have to check again. Finally feels great to have a tool to customize GNOME without needing to specify it is a tool in its name!