GNOME Bugzilla – Bug 783602
dark icons in routing sidebar
Last modified: 2017-09-22 09:23:41 UTC
Created attachment 353475 [details] screenshot The icons for the steps in the routing sidebar has a very dark black color (#000000), while most other icons in the UI have a less empty black (#2e3436) I think it would look more consistent if they were all #2e3436
Created attachment 353476 [details] mockup of how that would look
Created attachment 354651 [details] [review] utils: Add function to detect if set to prefer dark theme
Created attachment 354652 [details] [review] transitRouteLabel: Draw outline for dark color on dark theme Also add a property to override for print mode (should always treat as light theme).
Created attachment 354653 [details] [review] transitLegRow: Propagate the "print" property to the route label
The patches here right now are more of a preparatory nature, added support for having the route labels getting an outline around them when the color is below a certain threashhold when the app is set to prefer a dark theme. This is not directly related to the icon colors, but a nice-to-have I think.
Created attachment 359811 [details] [review] instructionRow: Use sidebar icon style for direction icons
Created attachment 359812 [details] [review] transitArrivalRow: Use sidebar icon style for icon
Created attachment 359813 [details] [review] transitLegRow: Use sidebar icon style for mode icon
Created attachment 359814 [details] [review] transitStopRow: Use sidebar icon style for icon
Created attachment 359815 [details] [review] transitItineraryRow: Use sidebar icon style for mode icon
Created attachment 359816 [details] [review] transitPlan: Change default route color to match icons
Works great for me! Only thing I noticed is that the icon color in the To and From field and these in the sidebar are still a tiny, tiny bit different in color (585d5e vs 4c4c4c). I don't think anyone will notice though :)
Attachment 354651 [details] pushed as b719aaf - utils: Add function to detect if set to prefer dark theme Attachment 354652 [details] pushed as 4249e77 - transitRouteLabel: Draw outline for dark color on dark theme Attachment 354653 [details] pushed as 6aa9e74 - transitLegRow: Propagate the "print" property to the route label Attachment 359811 [details] pushed as 8bd78a9 - instructionRow: Use sidebar icon style for direction icons Attachment 359812 [details] pushed as fe7cded - transitArrivalRow: Use sidebar icon style for icon Attachment 359813 [details] pushed as 3df8768 - transitLegRow: Use sidebar icon style for mode icon Attachment 359814 [details] pushed as 66f2145 - transitStopRow: Use sidebar icon style for icon Attachment 359815 [details] pushed as 1054c44 - transitItineraryRow: Use sidebar icon style for mode icon Attachment 359816 [details] pushed as 2c34cc0 - transitPlan: Change default route color to match icons