GNOME Bugzilla – Bug 783589
Second revision of meson build port
Last modified: 2017-07-05 12:45:31 UTC
Created attachment 353450 [details] [review] Improved meson build port After being involved on different meson build ports, I have been able to improve the meson build port of gnome-todo. The set of main changes is as follows: - Added ToDo website for PACKAGE_URL define. - Added generation of the enums schema. - Added a post install script for generating icon theme cache and compile different schemas. - Fixed documentation generation by using GTK prefixes. - Added mkdb_args, which will be available in the future meson releases. - Removed unused meson build options and changed enable-nls option to be enabled by default. - Fixed plugins to be created as shared modules. - Removed listed headers.
Created attachment 353811 [details] [review] Improved meson build port meson 0.41.0 has been release a couple of days ago, so I've decided to update the patch. The list of changes is as follows: - Use i18n module instead of using custom targets. - Changed application data information install directory to the new proposed 'metainfo' directory. - Use pkgconfig module's generate function to generate pc file. - Raised meson required version to 0.41.0.
Review of attachment 353811 [details] [review]: Looks like this patch doesn't apply against master.
Created attachment 354203 [details] [review] Improved meson build port My fault. I started working on a branch which was older than the one submitted. Here goes an updated patch.
Created attachment 354243 [details] [review] Improved meson build port A minor improvement to take advantage of the install_subdir function which makes the code cleaner.
Comment on attachment 354243 [details] [review] Improved meson build port Refreshingly nice. Thanks! Still keeping this bug open for future improvements.
Created attachment 354870 [details] [review] Performance improvements for meson buld port Some performance improvements for meson build port.
Review of attachment 354870 [details] [review]: Was the removal of docs/meson.build intentional?
Yes, I have removed it in purpose as it doesn't provide anything useful for the building step. It does only include the 'reference' directory, which is now referenced directly from the main meson build file in the source root directory.
Review of attachment 354870 [details] [review]: Let's go for it then!
Attachment 354870 [details] pushed as 7b304e9 - project: Performance improvements for meson build port